RFR: 8024508 Fix doclint issues in com.sun.nio.sctp

2013-09-10 Thread Chris Hegarty
Trivial doclint issues in the com.sun.nio.sctp public package. diff -r 4fd7abaf0a5f src/share/classes/com/sun/nio/sctp/Association.java --- a/src/share/classes/com/sun/nio/sctp/Association.java Mon Sep 09 13:44:30 2013 +0100 +++ b/src/share/classes/com/sun/nio/sctp/Association.java

Re: RFR: 8024508 Fix doclint issues in com.sun.nio.sctp

2013-09-10 Thread Alan Bateman
On 10/09/2013 10:09, Chris Hegarty wrote: Trivial doclint issues in the com.sun.nio.sctp public package. Looks okay to me. I'd suggest checking the bug database as there are existing bugs for this same issue. -Alan

Re: RFR: 8024508 Fix doclint issues in com.sun.nio.sctp

2013-09-10 Thread Andreas Rieber
Minor hint, the copyright header year update is missing. Andreas On 10.09.2013 11:09, Chris Hegarty wrote: Trivial doclint issues in the com.sun.nio.sctp public package. diff -r 4fd7abaf0a5f src/share/classes/com/sun/nio/sctp/Association.java ---

Re: RFR: 8024508 Fix doclint issues in com.sun.nio.sctp

2013-09-10 Thread Alan Bateman
On 10/09/2013 10:27, Andreas Rieber wrote: Minor hint, the copyright header year update is missing. Andreas We're not strictly required to do that each time, it's a confusing point that comes up regularly (with the result that we are inconsistent). There's a script checked into the top-level

Re: RFR: 8024508 Fix doclint issues in com.sun.nio.sctp

2013-09-10 Thread Andreas Rieber
On 10.09.2013 11:36, Alan Bateman wrote: On 10/09/2013 10:27, Andreas Rieber wrote: Minor hint, the copyright header year update is missing. Andreas We're not strictly required to do that each time, it's a confusing point that comes up regularly (with the result that we are inconsistent).

hg: jdk8/tl/jdk: 8023878: (fs) TEST_BUG java/nio/file/WatchService/SensitivityModifier.java fails intermittently

2013-09-10 Thread alan . bateman
Changeset: 909aced59bef Author:alanb Date: 2013-09-10 10:42 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/909aced59bef 8023878: (fs) TEST_BUG java/nio/file/WatchService/SensitivityModifier.java fails intermittently Reviewed-by: alanb Contributed-by: yiming.w...@oracle.com

Re: RFR: 8024508 Fix doclint issues in com.sun.nio.sctp

2013-09-10 Thread Chris Hegarty
As a point of process, and since the copyright year range update is not strictly required, I typically leave it out of individual bug fixes. I have seen too many times where it has caused unnecessary conflicts when sync'ing or backporting. -Chris. On 09/10/2013 10:44 AM, Andreas Rieber

hg: jdk8/tl/jdk: 8024501: sun.security.mscapi.Key has no definition of serialVersionUID

2013-09-10 Thread xuelei . fan
Changeset: c9083205e6eb Author:xuelei Date: 2013-09-10 21:31 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c9083205e6eb 8024501: sun.security.mscapi.Key has no definition of serialVersionUID Reviewed-by: weijun ! src/windows/classes/sun/security/mscapi/Key.java