Changeset: c35f6df5bce9
Author:sla
Date: 2013-11-01 10:08 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c35f6df5bce9
8027692: Remove java/lang/management/MemoryMXBean/LowMemoryTest2.sh from
ProblemList.txt
Reviewed-by: stefank, alanb
! test/ProblemList.txt
Hi Tristan,
From what I understand of the issue I see no problem with what you are
suggesting. Webrev?
-Chris.
On 01/11/2013 05:44, Tristan Yan wrote:
Hi Everyone
I am working on bug https://bugs.openjdk.java.net/browse/JDK-8022963.
Root cause for this bug is Windows API has inconsistent
Changeset: c59ccad6eb72
Author:sla
Date: 2013-11-01 15:10 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c59ccad6eb72
8027705: com/sun/jdi/JdbMethodExitTest.sh fails when a background thread is
generating events.
Reviewed-by: dcubed
! test/com/sun/jdi/JdbMethodExitTest.sh
Simple bug fix to new URLPermission class, caused by insufficient
parameter checking
of the constructor.
webrev: http://cr.openjdk.java.net/~michaelm/8027687/webrev.1/
Thanks,
Michael
Hi everyone
Please review the fix for JDK-8022963.
http://cr.openjdk.java.net/~pzhang/Tristan/8022963/webrev/
Description:
Since windows API has very inconsistent behavior on Teredo Tunneling
Pesudo-Interface, we removed this network interface for this test.
Thank you.
Tristan
On 01/11/2013
Looks good to me Michael.
Trivially, I'd replace 'new String(sb)' with 'sb.toString()' in
HostPortrange, but that's just me.
-Chris.
On 01/11/2013 14:46, Michael McMahon wrote:
Simple bug fix to new URLPermission class, caused by insufficient
parameter checking
of the constructor.
webrev:
A couple minor quibbles
- Since the length is know the StringBuilder can be created with a size.
- sb.toString() is probably more efficient than new String(sb)
- I would like to see some IDN URL cases in the tests.
Mike
On Nov 1 2013, at 07:46 , Michael McMahon michael.x.mcma...@oracle.com
Changeset: cc80c03c41e4
Author:vromero
Date: 2013-11-01 19:08 +
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/cc80c03c41e4
8027660: javac crash while creating LVT entry for a local variable defined in
an inner block
Reviewed-by: jjg
Contributed-by:
On 01/11/13 18:06, Mike Duigou wrote:
A couple minor quibbles
- Since the length is know the StringBuildiler can be created with a size.
Right, 255 is probably a good size to use.
- sb.toString() is probably more efficient than new String(sb)
Since Chris also suggests it, I'm curious why
Changeset: 8b4e1421a9b7
Author:jlahoda
Date: 2013-11-01 21:43 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/8b4e1421a9b7
8027310: Annotation Processor crashes with NPE
Summary: JCAnnotation.attribute is null when annotation type is unavailable
Reviewed-by: jjg,
Changeset: 6a6faa00acc4
Author:dxu
Date: 2013-11-01 14:40 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6a6faa00acc4
8027624: com/sun/crypto/provider/KeyFactory/TestProviderLeak.java unstable again
Reviewed-by: wetmore
!
The size to use is the length of the argument, which you're already using
for the loop.
On a separate note, is toLowerCase in a perf sensitive area? It makes an
assumption that the lowering will need to happen (by always allocating the
stringbuilder) but is that a common case? If this isn't perf
12 matches
Mail list logo
