Re: RFR: 7100957 : Java doesn't correctly handle the SOCKS protocol when used over IPv6

2014-01-06 Thread Dimitar Mavrodiev
The jtreg version I am using(4.1 fcs b05) seems to be correctly handling it. What jtreg version should I be using? On Mon, Jan 6, 2014 at 5:52 PM, Alan Bateman wrote: > On 06/01/2014 15:21, Dimitar Mavrodiev wrote: > >> Thanks, Chris. >> >> I've removed the dependency on the internal HttpServer.

Re: RFR: 7100957 : Java doesn't correctly handle the SOCKS protocol when used over IPv6

2014-01-06 Thread Dimitar Mavrodiev
Hi Alan, I wasn't aware that tests might run on machines without the IPv6 stack. Now the test is skipped should there be no IPv6 address configured on the loopback iface. I've also expanded the test to cover the case of DOMAIN_NAME, but I came across some infrastructure problems. It turned out th

Re: RFR: 7100957 : Java doesn't correctly handle the SOCKS protocol when used over IPv6

2014-01-06 Thread Chris Hegarty
The source changes look good to me too. I see Alan has commented on the test, and I agree. Trivially, can you also remove the dependency on the old internal HttpServer, and use the newer com.sun.net.httpserver API. It is easier to user, and more robust. You can see an example here [1]. -Chri

Re: JDK 9 RFR of JDK-8031201: Fix casting lint issues in java.net

2014-01-06 Thread Chris Hegarty
Looks good to me Joe. -Chris. On 6 Jan 2014, at 19:36, Joe Darcy wrote: > Hello, > > Please review the simple patch below to address > > JDK-8031201: Fix casting lint issues in java.net > > (The various ObjectInputStream.GetField.get methods which have a default > parameter, have an pro

Re: RFR: 7100957 : Java doesn't correctly handle the SOCKS protocol when used over IPv6

2014-01-06 Thread Chris Hegarty
On 06/01/14 16:05, Dimitar Mavrodiev wrote: The jtreg version I am using(4.1 fcs b05) seems to be correctly handling it. What jtreg version should I be using? See https://bugs.openjdk.java.net/browse/JDK-8026362 for a an example of this. Did you try to run your test without ::1 enabled? -Ch

Re: RFR: 7100957 : Java doesn't correctly handle the SOCKS protocol when used over IPv6

2014-01-06 Thread Alan Bateman
On 06/01/2014 15:21, Dimitar Mavrodiev wrote: Thanks, Chris. I've removed the dependency on the internal HttpServer. Here's another webrev https://googledrive.com/host/0B2CI6Ih--1t5bVVwbVlBRmpVMDg/2/index.html. I'm not 100% sure how jtreg handles TestNG tests throwing SkipException. If it doe

Re: JDK 9 RFR of JDK-8031201: Fix casting lint issues in java.net

2014-01-06 Thread Alan Bateman
On 06/01/2014 19:36, Joe Darcy wrote: Hello, Please review the simple patch below to address JDK-8031201: Fix casting lint issues in java.net This looks okay to me. -Alan

hg: jdk8/tl/jdk: 8030850: Setting .level=FINEST in logging configuration file doesn't work

2014-01-06 Thread daniel . fuchs
Changeset: d77a1c9fd5b8 Author:dfuchs Date: 2013-12-22 11:20 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d77a1c9fd5b8 8030850: Setting .level=FINEST in logging configuration file doesn't work Summary: setLevel(INFO) was called too early on root logger, causing the value f

JDK 9 RFR of JDK-8031201: Fix casting lint issues in java.net

2014-01-06 Thread Joe Darcy
Hello, Please review the simple patch below to address JDK-8031201: Fix casting lint issues in java.net (The various ObjectInputStream.GetField.get methods which have a default parameter, have an property-typed return value already.) Thanks, -Joe diff -r 9af7c1225730 src/share/classes

Re: RFR: 7100957 : Java doesn't correctly handle the SOCKS protocol when used over IPv6

2014-01-06 Thread Dimitar Mavrodiev
Thanks, Chris. I've removed the dependency on the internal HttpServer. Here's another webrev https://googledrive.com/host/0B2CI6Ih--1t5bVVwbVlBRmpVMDg/2/index.html. Best, Dimitar On Mon, Jan 6, 2014 at 4:18 PM, Chris Hegarty wrote: > The source changes look good to me too. > > I see Alan has c

Re: RFR: 7100957 : Java doesn't correctly handle the SOCKS protocol when used over IPv6

2014-01-06 Thread Dimitar Mavrodiev
Ok, better safe than sorry. Here's the webrev https://googledrive.com/host/0B2CI6Ih--1t5bVVwbVlBRmpVMDg/3/index.html. Best, Dimitar On Mon, Jan 6, 2014 at 6:31 PM, Chris Hegarty wrote: > On 06/01/14 16:18, Dimitar Mavrodiev wrote: > >> Yes, I've disabled IPv6 and it came out as successful in th

Re: RFR: 7100957 : Java doesn't correctly handle the SOCKS protocol when used over IPv6

2014-01-06 Thread Chris Hegarty
On 06/01/14 16:18, Dimitar Mavrodiev wrote: Yes, I've disabled IPv6 and it came out as successful in the report. Is it possible that jtreg behaves differently across different OSes? I am using it on Linux and OSX, the bug report mentions Windows. It is possible, but I don't see any special hand

Re: RFR: 7100957 : Java doesn't correctly handle the SOCKS protocol when used over IPv6

2014-01-06 Thread Dimitar Mavrodiev
Yes, I've disabled IPv6 and it came out as successful in the report. Is it possible that jtreg behaves differently across different OSes? I am using it on Linux and OSX, the bug report mentions Windows. On Mon, Jan 6, 2014 at 6:16 PM, Chris Hegarty wrote: > On 06/01/14 16:05, Dimitar Mavrodiev w

RFR: 8029354: URLPermission. throws llegalArgumentException: Invalid characters in hostname

2014-01-06 Thread Michael McMahon
http://cr.openjdk.java.net/~michaelm/8029354/9/webrev.1/ This is the forward port to JDK 9. The patch from 8 applies cleanly. Thanks, Michael