Re: RFR: 7100957 : Java doesn't correctly handle the SOCKS protocol when used over IPv6

2014-01-07 Thread Alan Bateman
On 07/01/2014 12:29, Dimitar Mavrodiev wrote: Hi Alan, I've fixed that. Here's the webrev https://googledrive.com/host/0B2CI6Ih--1t5bVVwbVlBRmpVMDg/4/index.html. Thanks for the update, it seems to be okay now for IPv6 disabled case. One thing I do see though is that the test fails intermitt

Re: JDK 9 RFR of 8031326: Use Class rather than Class in java.net method signatures

2014-01-07 Thread Michael McMahon
On 07/01/14 17:44, Alan Bateman wrote: On 07/01/2014 17:36, Joe Darcy wrote: Hello, Please review these changes to remove use of raw Class in some method signatures in java.net: JDK-8031326: Use Class rather than Class in java.net method signatures Patch below. This looks okay to

Re: JDK 9 RFR of 8031326: Use Class rather than Class in java.net method signatures

2014-01-07 Thread Chris Hegarty
Approved. -Chris. On 7 Jan 2014, at 17:36, Joe Darcy wrote: > Hello, > > Please review these changes to remove use of raw Class in some method > signatures in java.net: > >JDK-8031326: Use Class rather than Class in java.net method > signatures > > Patch below. > > Thanks, > > -J

JDK 9 RFR of 8031326: Use Class rather than Class in java.net method signatures

2014-01-07 Thread Joe Darcy
Hello, Please review these changes to remove use of raw Class in some method signatures in java.net: JDK-8031326: Use Class rather than Class in java.net method signatures Patch below. Thanks, -Joe --- a/src/share/classes/java/net/URL.javaTue Jan 07 09:17:56 2014 -0800 +++ b/

Re: JDK 9 RFR of 8031326: Use Class rather than Class in java.net method signatures

2014-01-07 Thread Alan Bateman
On 07/01/2014 17:36, Joe Darcy wrote: Hello, Please review these changes to remove use of raw Class in some method signatures in java.net: JDK-8031326: Use Class rather than Class in java.net method signatures Patch below. This looks okay to me. -Alan.

hg: jdk8/tl/jdk: 8031103: java.time.Duration has wrong Javadoc Comments in toDays() and toHours()

2014-01-07 Thread roger . riggs
Changeset: 1b503dd54b95 Author:rriggs Date: 2014-01-07 11:50 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1b503dd54b95 8031103: java.time.Duration has wrong Javadoc Comments in toDays() and toHours() Summary: Correct specification for Duration.toDays, toHours Reviewed-by: l

Re: RFR: 7100957 : Java doesn't correctly handle the SOCKS protocol when used over IPv6

2014-01-07 Thread Dimitar Mavrodiev
Hi Alan, I've fixed that. Here's the webrev https://googledrive.com/host/0B2CI6Ih--1t5bVVwbVlBRmpVMDg/4/index.html. I've made some changes in the test to ensure that the inet6 address family is available, there's also a flag controlling if the test should run. It now runs if the IPv6 stack is ava

Re: RFR: 7100957 : Java doesn't correctly handle the SOCKS protocol when used over IPv6

2014-01-07 Thread Alan Bateman
On 06/01/2014 16:39, Dimitar Mavrodiev wrote: Ok, better safe than sorry. Here's the webrev https://googledrive.com/host/0B2CI6Ih--1t5bVVwbVlBRmpVMDg/3/index.html. Can you verify that it passes okay when you run jtreg with -vmoption:-Djava.net.preferIPv4Stack=true . I ask because I don't see a