hg: jdk8/tl/jaxws: 8027908: serialVersionUID of javax.xml.bind.TypeConstraintException accidently changed

2014-01-13 Thread alan . bateman
Changeset: bd943bdbce05 Author:alanb Date: 2014-01-13 16:17 + URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/bd943bdbce05 8027908: serialVersionUID of javax.xml.bind.TypeConstraintException accidently changed Reviewed-by: alanb Contributed-by: iaroslav.savyts...@oracle.com

Re: RFR: 7100957 : Java doesn't correctly handle the SOCKS protocol when used over IPv6

2014-01-13 Thread Chris Hegarty
On 13 Jan 2014, at 19:23, Dimitar Mavrodiev wrote: > Hi Chris, > > I can't open the link, but yet I wouldn't mind if you folded your patch into > mine. How embarrassing. Our public facing server is temporarily offline so I copied the webrev to a temporary server just to verify it, then obviou

Re: RFR: 7100957 : Java doesn't correctly handle the SOCKS protocol when used over IPv6

2014-01-13 Thread Dimitar Mavrodiev
Hi Chris, I can't open the link, but yet I wouldn't mind if you folded your patch into mine. Thanks, Dimitar Sent from my mobile device. On Jan 13, 2014 9:11 PM, "Chris Hegarty" wrote: > Hi Dimitar, > > Thank you for following up with this. I came to the same conclusion as you > earlier today,

Re: RFR: 7100957 : Java doesn't correctly handle the SOCKS protocol when used over IPv6

2014-01-13 Thread Dimitar Mavrodiev
Hi Alan, I believe to have found and fixed what was causing the failures on Windows. Here's the webrev https://googledrive.com/host/0B2CI6Ih--1t5bVVwbVlBRmpVMDg/5/index.html. I modified java.net.SocksSocketImpl#readSocksReply(..) so that it doesn't give up on reading after the 3rd attempt, but in

Re: RFR: 7100957 : Java doesn't correctly handle the SOCKS protocol when used over IPv6

2014-01-13 Thread Chris Hegarty
Hi Dimitar, Thank you for following up with this. I came to the same conclusion as you earlier today, though I noticed it because the test SocksServer was sending a single byte at a time, for the initial reply. I took your latest patch and applied a few minor cleanups, as follows: http://t4.i

Re: RFR: (8030875) Macros for checking and returning on exceptions

2014-01-13 Thread David Holmes
Hi Roger, On 11/01/2014 1:37 AM, roger riggs wrote: Please review: To enable native code checking consistently for thrown exceptions, the macros in net_util.h and java/util/jar/pack/coding.cpp are made consolidated and promoted to jni_util.h webrev: http://cr.openjdk.java.net/~rriggs/webrev-ch