Thanks Eric,
Pushed
http://hg.openjdk.java.net/jdk9/dev/jdk/rev/e0d1a825848f
There was a small issue of secs vs millis. Your webrev used 5 millis as
a sleep rather than 5000. I fixed this before pushing.
Also, with the changes the time for the test increased so I trivially
added a change t
Trivial typo fix.
diff --git a/src/share/classes/java/net/HttpCookie.java
b/src/share/classes/java/net/HttpCookie.java
--- a/src/share/classes/java/net/HttpCookie.java
+++ b/src/share/classes/java/net/HttpCookie.java
@@ -74,7 +74,7 @@
private boolean httpOnly; // HttpOnly ... i.e. not ac
Hi Chris,
Thanks for the push. I'm glad to learn the modern way from your refactor.
- Cheers,
Eric
On 2014/3/31 18:37, Chris Hegarty wrote:
Thanks Eric,
Pushed
http://hg.openjdk.java.net/jdk9/dev/jdk/rev/e0d1a825848f
There was a small issue of secs vs millis. Your webrev used 5 millis
as a
Hi Chris!
Would it be good to include a couple more typo fixes in this change?
diff --git a/src/share/classes/java/net/DatagramSocket.java
b/src/share/classes/java/net/DatagramSocket.java
--- a/src/share/classes/java/net/DatagramSocket.java
+++ b/src/share/classes/java/net/DatagramSocket.java
Thanks Ivan, I'll add them.
-Chris.
On 31/03/14 15:48, Ivan Gerasimov wrote:
Hi Chris!
Would it be good to include a couple more typo fixes in this change?
diff --git a/src/share/classes/java/net/DatagramSocket.java
b/src/share/classes/java/net/DatagramSocket.java
--- a/src/share/classes/java
Chris/Ivan's changes look good to me.
Brad
On 3/31/2014 7:59 AM, Chris Hegarty wrote:
Thanks Ivan, I'll add them.
-Chris.
On 31/03/14 15:48, Ivan Gerasimov wrote:
Hi Chris!
Would it be good to include a couple more typo fixes in this change?
diff --git a/src/share/classes/java/net/Datagra
