Re: RFR: JDK-8077377 - java/net/MulticastSocket/SetOutgoingIf.java fails intermittently with NullPointerException

2015-05-26 Thread Chris Hegarty
Looks fine Mark. We fixed a few other tests recently to be more tolerant of network interference. -Chris. > On 26 May 2015, at 20:34, Mark Sheppard wrote: > > Hi > please oblige and review the following change > http://cr.openjdk.java.net/~msheppar/8077377/webrev/ > > to address the issue

Re: RFR: JDK-8041677 - java/net/MulticastSocket/TestInterfaces failed on Oracle VM Virtual Ethernet Adapter

2015-05-26 Thread Chris Hegarty
Looks fine. Not for now, but sometime we should consider adding a utility to the test library to retrieve an appropriate set of network interfaces suitable for use in tests ( rather than patching all these tests individually ). -Chris. > On 26 May 2015, at 20:21, Mark Sheppard wrote: > > Hi

Re: RFR: JDK-8077377 - java/net/MulticastSocket/SetOutgoingIf.java fails intermittently with NullPointerException

2015-05-26 Thread Mark Sheppard
Hi Alan, yes, that's about it. The test is just logging that expected interface is not equal to from. So ignoring the stray packet seems reasonable and overcomes the NPE. We could log the fact that a stray packet has been received if (from != null) { if

Re: RFR: JDK-8041677 - java/net/MulticastSocket/TestInterfaces failed on Oracle VM Virtual Ethernet Adapter

2015-05-26 Thread Mark Sheppard
Thanks Alan On 26/05/2015 20:34, Alan Bateman wrote: On 26/05/2015 20:21, Mark Sheppard wrote: Hi please oblige and review the following change http://cr.openjdk.java.net/~msheppar/8041677/webrev/ which addresses the issue https://bugs.openjdk.java.net/browse/JDK-8041677 analysis has shown

Re: RFR: JDK-8077377 - java/net/MulticastSocket/SetOutgoingIf.java fails intermittently with NullPointerException

2015-05-26 Thread Alan Bateman
On 26/05/2015 20:34, Mark Sheppard wrote: Hi please oblige and review the following change http://cr.openjdk.java.net/~msheppar/8077377/webrev/ to address the issue https://bugs.openjdk.java.net/browse/JDK-8077377 it is possible that "stray" packets can be received in this MulticastSocket t

RFR: JDK-8077377 - java/net/MulticastSocket/SetOutgoingIf.java fails intermittently with NullPointerException

2015-05-26 Thread Mark Sheppard
Hi please oblige and review the following change http://cr.openjdk.java.net/~msheppar/8077377/webrev/ to address the issue https://bugs.openjdk.java.net/browse/JDK-8077377 it is possible that "stray" packets can be received in this MulticastSocket test, and this results in a NPE from the Net

Re: RFR: JDK-8041677 - java/net/MulticastSocket/TestInterfaces failed on Oracle VM Virtual Ethernet Adapter

2015-05-26 Thread Alan Bateman
On 26/05/2015 20:21, Mark Sheppard wrote: Hi please oblige and review the following change http://cr.openjdk.java.net/~msheppar/8041677/webrev/ which addresses the issue https://bugs.openjdk.java.net/browse/JDK-8041677 analysis has shown that the Teredo interfaces causes issue, due to its dy

RFR: JDK-8041677 - java/net/MulticastSocket/TestInterfaces failed on Oracle VM Virtual Ethernet Adapter

2015-05-26 Thread Mark Sheppard
Hi please oblige and review the following change http://cr.openjdk.java.net/~msheppar/8041677/webrev/ which addresses the issue https://bugs.openjdk.java.net/browse/JDK-8041677 analysis has shown that the Teredo interfaces causes issue, due to its dynamic configuration, when included in the t