Re: Patch for adding SO_REUSEPORT socket option

Hi Kishor Did you mean to include the patch with this message? If you send it, I can convert it to a webrev and put it on the cr.openjdk server for review Thanks Michael On 16/11/15 18:49, Kharbas, Kishor wrote: Hello all, I request the community to review a patch for adding SO_REUSEPORT su

RE: Patch for adding SO_REUSEPORT socket option

Hi Michael, Thank you very much for your email. The version 1 of the patch is already uploaded at http://cr.openjdk.java.net/~mcberg/jdk/6432031/webrev.01/. The link is also available from https://bugs.openjdk.java.net/browse/JDK-6432031. We just completed the version 2 which implements the SO

Re: Patch for adding SO_REUSEPORT socket option

there would appear to be a link to a webrev in the JBS bug https://bugs.openjdk.java.net/browse/JDK-6432031 http://cr.openjdk.java.net/~mcberg/jdk/6432031/webrev.01/ I presume t

Re: Patch for adding SO_REUSEPORT socket option

Thanks Mark. I'll take a look at the patch then - Michael On 19/11/15 14:52, Mark Sheppard wrote: there would appear to be a link to a webrev in the JBS bug https://bugs.openjdk.java.net/browse/JDK-6432031 http://cr.openjdk.java.net/~mcber

RE: Patch for adding SO_REUSEPORT socket option

Yes, that was our first version of the patch. We just completed the second version which will be uploaded soon, hopefully today. In the new version, we implemented the SO_REUSEPORT as an extended socket option (jdk.net.ExtendedSocketOptions) instead of the standard socket option. Once we are d

Re: Patch for adding SO_REUSEPORT socket option

Hi Yingqi, I think we should consider making it a standard option if there is a reasonable prospect that all the major platforms will eventually support it. Even if a particular platform does not support it initially (such as Windows) the API allows for this possibility by throwing Unsupported

RE: Patch for adding SO_REUSEPORT socket option

Thank you for your email, Michael! We will have both implementations available so that experts here can discuss and review the pros and cons of each way :) The performance gains of enabling SO_REUSEPORT is significant, especially on the multi-core systems. We would like to have it enabled in Op

Re: Patch for adding SO_REUSEPORT socket option

On 16/11/2015 18:49, Kharbas, Kishor wrote: P.S. Based on Alan Baleman's comment on JBS, we are in meanwhile working on adding this option to 'java.net.ExtendedSocketOption'. My comment in the bug was just to bring up the question as to whether this should be a standard or JDK-specific so

RE: Patch for adding SO_REUSEPORT socket option

Hi Alan and Michael, Thank very much to both of you for your feedback. Currently, I think the only platform that does not have SO_REUSEPORT is Windows. As Michael mentioned, API allows this possibility by throwing SocketException with message "Invalid option". Older kernel that does not suppor