RE: Patch for adding SO_REUSEPORT socket option

2015-11-22 Thread Lu, Yingqi
Hi Alan, One more question please :) I want to make sure I understand correctly on your following suggestion. In order to use supportedOptions method to test SO_REUSEPORT, I will need to first write a native function to check if SO_REUSEPORT is supported. Then, in the defaultOptions method, I d

RE: Patch for adding SO_REUSEPORT socket option

2015-11-22 Thread Lu, Yingqi
Hi Alan, Thank you very much for your suggestions. This is my first time contributing to OpenJDK. Really appreciate your help :) In java.net.StandardSocketOptions, I modify the specification for SO_REUSEPORT as following. Please let me know your feedback. Once we agree on this, we can continue

Re: RFR: JDK-8134577 - Eliminate or standardize a replacement for sun.net.spi.nameservice.NameServiceDescriptor

2015-11-22 Thread Mark Sheppard
Alan thanks for the feedback ... the implementation is based on what is currently being used in the tests via the existing set of NameService implementations. yes, the processing of the hosts file returns the first mapping it encounters. The functionality is to provide similar to that which c

Re: RFR: JDK-8134577 - Eliminate or standardize a replacement for sun.net.spi.nameservice.NameServiceDescriptor

2015-11-22 Thread Alan Bateman
On 12/11/2015 16:46, Mark Sheppard wrote: Hi, based on feedback from first review the updates have been amended please oblige and review the current set of changes as per http://cr.openjdk.java.net/~msheppar/8134577/webrev.02/ I'm looked through the changes in this webrev. At a high-leve

Re: Patch for adding SO_REUSEPORT socket option

2015-11-22 Thread Alan Bateman
On 21/11/2015 02:08, Lu, Yingqi wrote: Hi Alan, Please let me know if there is anything we can do at the meantime to help. We are more than happy to help. Sorry, I wasn't clear. I meant that you will need to work on the javadoc. In many of the classes you've added the following to the spec