Hi Alan,
I heard that the feature freeze for OpenJDK9 is approaching. Given the
significant performance impact (up to 1.93x with Hadoop Distributed File
System) this feature provides and the status of the existing work, we would be
really interested in see this feature to be approved for OpenJD
OK, will do.
Thanks,
Lucy
-Original Message-
From: Alan Bateman [mailto:alan.bate...@oracle.com]
Sent: Monday, December 07, 2015 1:01 PM
To: Lu, Yingqi ; Volker Simonis
Cc: Michael McMahon ; Kaczmarek, Eric
; net-dev@openjdk.java.net; Kharbas, Kishor
Subject: Re: Patch for adding SO_
On 07/12/2015 18:59, Lu, Yingqi wrote:
Oh, I got it now. You want SO_REUSEPORT to be disabled by default for both
ServerSocketChannelImpl and SocketChannelImpl.
I am actually OK either way. Alan/Michael, what is your take on this? If we all think
"default off" is the correct/better way to go
Oh, I got it now. You want SO_REUSEPORT to be disabled by default for both
ServerSocketChannelImpl and SocketChannelImpl.
I am actually OK either way. Alan/Michael, what is your take on this? If we all
think "default off" is the correct/better way to go, we can just simply remove
that block an
On Mon, Dec 7, 2015 at 7:02 PM, Lu, Yingqi wrote:
> Hi Volker,
>
> Thank you very much for your feedback.
>
> 1. For the following code, I will do it as platform specific as you suggested.
> 37 /* Defines SO_REUSEPORT */
> 38 #ifndef SO_REUSEPORT
> 39 #define SO_REUSEPORT 15
> 40 #endif
>
Hi Volker,
Thank you very much for your feedback.
1. For the following code, I will do it as platform specific as you suggested.
37 /* Defines SO_REUSEPORT */
38 #ifndef SO_REUSEPORT
39 #define SO_REUSEPORT 15
40 #endif
2. I will remove the setReusePort and getReusePort methods from
So
Hi Lucy,
thanks for updating the change and sorry for the late review. It looks
pretty good now. Please find my comments below:
genSocketOptionRegistry.c
net_util_md.h
nio_util.h
socket_md.h
I'm a little concerned about the following code:
37 /* Defines SO_REUSEPORT */
Michael,
Thank you for confirming this. I will drop
test/java/net/Socket/setReusePort/Basic.java as well since that was added for
testing the setReusePort and getReusePort ☺
Thanks,
Lucy
From: Michael McMahon [mailto:michael.x.mcma...@oracle.com]
Sent: Monday, December 07, 2015 9:13 AM
To: Lu,
Yes, since the functionality is basically duplicated across the two
mechanisms
and since setOption/getOption already exists, the only new part of the API
is the SO_REUSEPORT option itself in StandardSocketOptions.
- Michael
On 07/12/15 17:04, Lu, Yingqi wrote:
Hi Alan and Michael,
Thank you
Hi Alan and Michael,
Thank you very much for your detailed feedback. Before I start modify the code,
I want to make sure I understand correctly. Regarding the following comment, do
you mean that we should remove the setReusePort and getReusePort methods? If
yes, we can easily remove them, and k
On 02/12/2015 17:08, Lu, Yingqi wrote:
Hi All,
A quick check here. Does anyone get a chance to try the most recent
patch? Any feedback and comments?
Thanks,
Lucy
I looked through the latest webrev (webrev.05) and it's looking quite good.
I agree with Michael, we should decide whether
Hi Lucy,
Sorry for the delay in getting back. I think it is getting closer now.
I should have mentioned this before, but now that all socket types
support the setOption/getOption methods, I'm not sure it is necessary
to have explicit per option set/get methods. These methods were only
added in JD
12 matches
Mail list logo
