Re: RFR: 8147962: URL should handle lower-casing of protocol locale-independently

2016-01-22 Thread Alan Bateman
On 21/01/2016 17:27, Claes Redestad wrote: Hi, using String.toLowerCase() in URL allows some strings to lower-case to a string that'd be invalid, e.g. "FILE".toLowerCase() -> "f\u0131le" in turkish locales. This patch suggests using the locale-independent String.toLowerCase(Locale.ENGLISH

Re: RFR: 8147962: URL should handle lower-casing of protocol locale-independently

2016-01-22 Thread Claes Redestad
On 2016-01-22 12:29, Alan Bateman wrote: On 21/01/2016 17:27, Claes Redestad wrote: Hi, using String.toLowerCase() in URL allows some strings to lower-case to a string that'd be invalid, e.g. "FILE".toLowerCase() -> "f\u0131le" in turkish locales. This patch suggests using the locale-in

RFR: JDK-8147862 - Null check too late in sun.net.httpserver.ServerImpl

2016-01-22 Thread Mark Sheppard
Hi please oblige and review the small change http://cr.openjdk.java.net/~msheppar/8147862/webrev/ to address https://bugs.openjdk.java.net/browse/JDK-8147862 it was observed that a null check on a SocketChannel object in the Disptacher.run() method within ServerImpl, should be earlier in the

Re: RFR: 8147962: URL should handle lower-casing of protocol locale-independently

2016-01-22 Thread Alan Bateman
On 22/01/2016 12:29, Claes Redestad wrote: : http://cr.openjdk.java.net/~redestad/8147962/webrev.02/ This looks good to me. -Alan

Re: RFR: 8147962: URL should handle lower-casing of protocol locale-independently

2016-01-22 Thread Claes Redestad
On 2016-01-22 14:38, Alan Bateman wrote: On 22/01/2016 12:29, Claes Redestad wrote: : http://cr.openjdk.java.net/~redestad/8147962/webrev.02/ This looks good to me. -Alan Thanks! /Claes

Re: RFR: JDK-8147862 - Null check too late in sun.net.httpserver.ServerImpl

2016-01-22 Thread Chris Hegarty
On 22/01/16 12:36, Mark Sheppard wrote: Hi please oblige and review the small change http://cr.openjdk.java.net/~msheppar/8147862/webrev/ Thanks for fixing this Mark. This was originally my mistake :-( -Chris. to address https://bugs.openjdk.java.net/browse/JDK-8147862 it was observed

Re: RFR: 8147962: URL should handle lower-casing of protocol locale-independently

2016-01-22 Thread Chris Hegarty
On 22/01/16 13:38, Claes Redestad wrote: On 2016-01-22 14:38, Alan Bateman wrote: On 22/01/2016 12:29, Claes Redestad wrote: : http://cr.openjdk.java.net/~redestad/8147962/webrev.02/ Looks good. -Chris.

Re: RFR 8065076/9, test/java/net/SocketPermission/SocketPermissionTest.java failed intermittently

2016-01-22 Thread Chris Hegarty
On 21/01/16 22:55, Felix Yang wrote: Hi Chris, your fix is cool. I will assign the bug to you:) a comment on this fix. The test changed system SecurityManager and it is not executed with othervm mode. I think you need to rollback the change after test. I will revert the change and h