Re: RFR: 8087112 HTTP API and HTTP/1.1 implementation

2016-02-17 Thread Roger Riggs
Hi Michael, Looks great! With a new package, the doc will be important to help get developers started. The package-info.java should help a bit more getting started. The examples in the HttpRequest are very informative, either the package-java should show an example or be more explicit that

Re: Patch for adding SO_REUSEPORT socket option

2016-02-17 Thread Volker Simonis
Just wanted to report that from the AIX side everything looks clean and ready to go. Regards, Volker On Wed, Feb 17, 2016 at 5:56 PM, Seán Coffey wrote: > One comment on the supportability side from me : > > java/net/AbstractPlainDatagramSocketImpl.java > >> + case SO_REUSEPORT: >> +

Re: Patch for adding SO_REUSEPORT socket option

2016-02-17 Thread Seán Coffey
One comment on the supportability side from me : java/net/AbstractPlainDatagramSocketImpl.java > + case SO_REUSEPORT: > + if (o == null || !(o instanceof Boolean)) { > + throw new SocketException("bad argument for SO_REUSEPORT"); > + } > +

Re: RFR: 8087112 HTTP API and HTTP/1.1 implementation

2016-02-17 Thread Paul Sandoz
> On 4 Feb 2016, at 17:14, Michael McMahon wrote: > > Hi, > > The following webrevs are for the initial implementation of JEP 110. > Most of it is in the jdk repository with some build configuration in the top > level repo for putting this code in its own module (java.httpclient). > > http://c

Re: Patch for adding SO_REUSEPORT socket option

2016-02-17 Thread Alan Bateman
On 17/02/2016 11:43, Chris Hegarty wrote: I know this has gone through several rounds of review already. I do not want to stall progress, I am reasonably happy with the changes, but I have a few comments ( that can be addressed later, if needed ). - MulticastSocket.java: I would add a javado

Re: Patch for adding SO_REUSEPORT socket option

2016-02-17 Thread Chris Hegarty
From: net-dev [mailto:net-dev-boun...@openjdk.java.net] On Behalf Of Lu, Yingqi Sent: Thursday, February 11, 2016 9:47 AM To: Alan Bateman ; Volker Simonis ; Michael McMahon Cc: Kaczmarek, Eric ; Viswanathan, Sandhya ; Kharbas, Kishor ; Aundhe, Shirish ; net-dev@openjdk.java.net Subject: RE:

Re: Patch for adding SO_REUSEPORT socket option

2016-02-17 Thread Alan Bateman
On 17/02/2016 09:22, Volker Simonis wrote: Hi Alan, I'm just running a quick test build on AIX to see if everything is still working. I'll let you know once it completes (latest today evening). I've done the same and I think we need to drop the patches to the DatagramChannel multicast tests

Re: Patch for adding SO_REUSEPORT socket option

2016-02-17 Thread Volker Simonis
Hi Alan, I'm just running a quick test build on AIX to see if everything is still working. I'll let you know once it completes (latest today evening). Thanks, Volker On Tue, Feb 16, 2016 at 11:18 PM, Alan Bateman wrote: > > > On 16/02/2016 18:03, Lu, Yingqi wrote: >> >> Hi Alan, >> >> I am won