Re: RFR: 8154185: Drop code to support Windows XP in DefaultDatagramSocketImplFactory

2016-04-13 Thread Claes Redestad
On 04/13/2016 11:43 PM, Chris Hegarty wrote: On 13 Apr 2016, at 22:31, Claes Redestad wrote: Hi, since we're dropping support for Windows XP in JDK 9, we can simplify initialization of DefaultDatagramSocketImplFactory. Bug: https://bugs.openjdk.java.net/browse/JDK-8154185 Webrev: http://cr.o

Re: RFR: 8154185: Drop code to support Windows XP in DefaultDatagramSocketImplFactory

2016-04-13 Thread Chris Hegarty
On 13 Apr 2016, at 22:31, Claes Redestad wrote: > > Hi, > > since we're dropping support for Windows XP in JDK 9, we can simplify > initialization of DefaultDatagramSocketImplFactory. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8154185 > Webrev: http://cr.openjdk.java.net/~redestad/81541

RFR: 8154185: Drop code to support Windows XP in DefaultDatagramSocketImplFactory

2016-04-13 Thread Claes Redestad
Hi, since we're dropping support for Windows XP in JDK 9, we can simplify initialization of DefaultDatagramSocketImplFactory. Bug: https://bugs.openjdk.java.net/browse/JDK-8154185 Webrev: http://cr.openjdk.java.net/~redestad/8154185/webrev.01/ Thanks! /Claes

Re: RFR: 8087124 HTTP/2 implementation

2016-04-13 Thread Simone Bordet
Hi, On Wed, Apr 6, 2016 at 4:08 PM, Michael McMahon wrote: > Hi, > > This is the webrev for the HTTP/2 part of JEP 110. > > http://cr.openjdk.java.net/~michaelm/8087124/webrev.1/index.html API I have already mentioned in 2 previous messages my feedback about the API, but a few of my concerns ha

Re: RFR JDK-8153353: HPACK implementation

2016-04-13 Thread Chris Hegarty
Pavel, Overall this is very good. I have mostly minor comments. > Though this is an implementation only package, it could use a few more > comments > to support maintainers. In the package.html, a couple of hints about what > classes are > the external interface would be useful and an example