Re: ALPN and HTTP/2 client

2016-04-18 Thread Simone Bordet
Hi, On Mon, Apr 18, 2016 at 10:09 PM, Michael McMahon wrote: > Hi, > > ALPN is set in the HttpConnection class. > > Checking the exact ciphers selected is not implemented > yet. That will come later. I am guessing checking for the actual application protocol too ? Sending "h2" via ALPN does not

Re: ALPN and HTTP/2 client

2016-04-18 Thread Michael McMahon
Hi, ALPN is set in the HttpConnection class. Checking the exact ciphers selected is not implemented yet. That will come later. I am currently updating the implementation to get rid of the two threads per connection limitation and will have a new webrev then. So I will address other review comm

Re: RFR JDK-8153353: HPACK implementation

2016-04-18 Thread Chris Hegarty
On 18/04/16 15:30, Pavel Rappo wrote: On 13 Apr 2016, at 10:10, Chris Hegarty wrote: A general comment; Quite a number of classes, especially Encoder and Decoder, would benefit from a few relatively lightweight comments, e.g. IntegerReader I would like to address it after the initial push.

Re: RFR: 8154454: Fix compilation issue in PlainSocketImpl

2016-04-18 Thread Claes Redestad
Thanks for the quick review Chris, I'll push as soon as JPRT runs look green. /Claes On 04/18/2016 04:45 PM, Chris Hegarty wrote: Looks ok Claes. -Chris. On 18/04/16 15:38, Claes Redestad wrote: Hi, a small omission in JDK-8154238 cause Windows builds to fail. Sorry about that, see patch t

Re: RFR: 8154454: Fix compilation issue in PlainSocketImpl

2016-04-18 Thread Chris Hegarty
Looks ok Claes. -Chris. On 18/04/16 15:38, Claes Redestad wrote: Hi, a small omission in JDK-8154238 cause Windows builds to fail. Sorry about that, see patch to fix this below (I was 100% certain I had run this through JPRT last week) Bug: https://bugs.openjdk.java.net/browse/JDK-8154454 Th

RFR: 8154454: Fix compilation issue in PlainSocketImpl

2016-04-18 Thread Claes Redestad
Hi, a small omission in JDK-8154238 cause Windows builds to fail. Sorry about that, see patch to fix this below (I was 100% certain I had run this through JPRT last week) Bug: https://bugs.openjdk.java.net/browse/JDK-8154454 Thanks! /Claes diff -r 3459ee432728 src/java.base/windows/classes

Re: RFR JDK-8153353: HPACK implementation

2016-04-18 Thread Pavel Rappo
> On 13 Apr 2016, at 10:10, Chris Hegarty wrote: > > A general comment; Quite a number of classes, especially Encoder and Decoder, > would benefit from a few relatively lightweight comments, e.g. IntegerReader I would like to address it after the initial push. If possible. Other than that, I ha

ServiceLoader for HTTP/2 and WebSocket clients

2016-04-18 Thread Simone Bordet
Hi, is there any plan to make the new HTTP/2 and WebSocket client implementation replaceable via a ServiceLoader mechanism ? Thanks ! -- Simone Bordet http://bordet.blogspot.com --- Finally, no matter how good the architecture and design are, to deliver bug-free software with optimal performanc

ALPN and HTTP/2 client

2016-04-18 Thread Simone Bordet
Hi, I am missing where the ALPN negotiation is performed in the new HTTP/2 client code, can you direct me at where this is done ? The HTTP/2 spec requires to close the connection with INADEQUATE_SECURITY if the cipher does not meet the HTTP/2 requirements, but I don't see this code ? SSLEngine.g

Re: RFR: 8154238: Drop code to support Windows XP in windows socket impl

2016-04-18 Thread Chris Hegarty
On 18/04/16 11:09, Claes Redestad wrote: On 04/18/2016 12:06 PM, Chris Hegarty wrote: On 18/04/16 11:01, Alan Bateman wrote: On 18/04/2016 10:45, Chris Hegarty wrote: The changes look fine. Maybe the bug description should be updated a before pushing, it looks like it affects only legacy net

Re: RFR: 8154238: Drop code to support Windows XP in windows socket impl

2016-04-18 Thread Claes Redestad
On 04/18/2016 12:06 PM, Chris Hegarty wrote: On 18/04/16 11:01, Alan Bateman wrote: On 18/04/2016 10:45, Chris Hegarty wrote: The changes look fine. Maybe the bug description should be updated a before pushing, it looks like it affects only legacy networking code and not NIO. Maybe "... and a

Re: RFR: 8154238: Drop code to support Windows XP in windows socket impl

2016-04-18 Thread Chris Hegarty
On 18/04/16 11:01, Alan Bateman wrote: On 18/04/2016 10:45, Chris Hegarty wrote: The changes look fine. Maybe the bug description should be updated a before pushing, it looks like it affects only legacy networking code and not NIO. Maybe "... and async channels" ? The changes to the NIO code

Re: RFR: 8154238: Drop code to support Windows XP in windows socket impl

2016-04-18 Thread Claes Redestad
On 04/18/2016 12:01 PM, Alan Bateman wrote: On 18/04/2016 10:45, Chris Hegarty wrote: The changes look fine. Maybe the bug description should be updated a before pushing, it looks like it affects only legacy networking code and not NIO. Maybe "... and async channels" ? The changes to the NIO c

Re: RFR: 8154238: Drop code to support Windows XP in windows socket impl

2016-04-18 Thread Claes Redestad
On 04/18/2016 11:45 AM, Chris Hegarty wrote: On 14/04/16 13:49, Claes Redestad wrote: Hi, more code in the Windows socket implementation that can be dropped Bug: https://bugs.openjdk.java.net/browse/JDK-8154238 Webrev: http://cr.openjdk.java.net/~redestad/8154238/webrev.01/ The changes look

Re: RFR: 8154238: Drop code to support Windows XP in windows socket impl

2016-04-18 Thread Alan Bateman
On 18/04/2016 10:45, Chris Hegarty wrote: The changes look fine. Maybe the bug description should be updated a before pushing, it looks like it affects only legacy networking code and not NIO. Maybe "... and async channels" ? The changes to the NIO code look okay but probably should be split in

Re: RFR: 8154238: Drop code to support Windows XP in windows socket impl

2016-04-18 Thread Chris Hegarty
On 14/04/16 13:49, Claes Redestad wrote: Hi, more code in the Windows socket implementation that can be dropped Bug: https://bugs.openjdk.java.net/browse/JDK-8154238 Webrev: http://cr.openjdk.java.net/~redestad/8154238/webrev.01/ The changes look fine. Maybe the bug description should be upd

Re: [JDK-8016521] IPV6 address selection

2016-04-18 Thread Chris Hegarty
On 12/04/16 21:27, Bernd Eckenfels wrote: Hello, a while back I brought up the discussion that there is no preferIPV6=system (or similar) setting which allows to turn off the reordering of address families by Java. Because only the OS can try to correctly do target address determinaton. A Bug