Re: RFR: 8155888: java/net/httpclient/QuickResponses.java intermittently failed with java.util.ConcurrentModificationException

2016-05-06 Thread Roger Riggs
+1 On 5/6/2016 1:04 PM, Chris Hegarty wrote: On 5 May 2016, at 12:29, Michael McMahon wrote: Another occasional test case failure. It's a concurrent modification exception caused by modifying a list during processing of the list (by the same thread). The solution is to keep separate lists

Re: RFR: 8155888: java/net/httpclient/QuickResponses.java intermittently failed with java.util.ConcurrentModificationException

2016-05-06 Thread Chris Hegarty
On 5 May 2016, at 12:29, Michael McMahon wrote: > Another occasional test case failure. It's a concurrent modification > exception caused > by modifying a list during processing of the list (by the same thread). The > solution > is to keep separate lists of the modifications and to process them

Re: RFR JDK-8087113: Websocket API and implementation

2016-05-06 Thread Pavel Rappo
> On 6 May 2016, at 09:16, Felix Yang wrote: > > Hi Pavel, > several comments: > > 1. WebSocket.request(long n) is documented as " > > @throws IllegalArgumentException if n < -1 > " > > It looks meaningless to allow 0. First of all, the way `request` is defined now is by no means meanin

Re: RFR JDK-8087113: Websocket API and implementation

2016-05-06 Thread Felix Yang
Hi Pavel, several comments: 1. WebSocket.request(long n) is documented as " @throws IllegalArgumentException if n < -1 " It looks meaningless to allow 0. 2. Some concern on the way of handling close. Consider following scenario. * obtain a ws connection * message communications bala