Re: RFR 8016521: InetAddress should not always re-order addresses returned from name service

2016-05-10 Thread ecki
Hello, Love it. Not sure about two things, first of all if there are more test cases (especially assertions) needed and secondly how to handle the prefer=System case for anyAddr and local. Currently it seems to prefer v4 (since this is the current default) howver i would expect in the system

Re: RFR JDK-8087113: Websocket API and implementation

2016-05-10 Thread Pavel Rappo
Hi Simone, > On 4 Apr 2016, at 20:07, Simone Bordet wrote: > > In my experience, once you get rid of exception throwing in async API > everything becomes much simpler, especially "deep" exceptions related > to invalid implementation internal states. Am I right saying

RFR 8016521: InetAddress should not always re-order addresses returned from name service

2016-05-10 Thread vyom
Hi All, Please review the code changes for the below issue. Bug : JDK-8016521 : InetAddress should not always re-order addresses returned from name service Webrev : http://cr.openjdk.java.net/~vtewari/8016521/webrev0.0/index.html

RFR(S): 8156521: Minor Fixes and cleanups in NetworkInterface.c

2016-05-10 Thread Langer, Christoph
Hi all, can I please get a review for a change to NetworkInterface.c bugreport: https://bugs.openjdk.java.net/browse/JDK-8156521 webrev: http://cr.openjdk.java.net/~clanger/webrevs/8156521.0/ Apart from quite a few whitespace changes to clean up the coding, I went through and replaced all

Re: RFR 8156509/9: Mark java/net/httpclient/security/Security.java as intermittently failing

2016-05-10 Thread Michael McMahon
I'd prefer to hold off with this change Felix. I recently pushed a change to that test which removes the hardcoded port numbers and also fixes another problem with the test. - Michael. On 10/05/16 04:17, Felix Yang wrote: Hi there, please review the following patch to mark