Re: RFR JDK-8156742: Miscellaneous WebSocket API improvements

2016-05-31 Thread Simone Bordet
Pavel, On Tue, May 31, 2016 at 7:25 PM, Pavel Rappo wrote: > Hi, > > Could you please review the following change for JDK-8156742? > > http://cr.openjdk.java.net/~prappo/8156742/webrev.01/ Comments on the API only. Looks much cleaner, good job. I like

RFR JDK-8156742: Miscellaneous WebSocket API improvements

2016-05-31 Thread Pavel Rappo
Hi, Could you please review the following change for JDK-8156742? http://cr.openjdk.java.net/~prappo/8156742/webrev.01/ This change addresses the first group of WebSocket API refinements and enhancements from [1]. 1. Change method `Builder#connectTimeout(long, TimeUnit)` to

Re: RFR [9] 8085785: sun/net/www/protocol/http/ZoneId.java timeout intermittently

2016-05-31 Thread Seán Coffey
Looks fine to me also Chris. Regards, Sean. On 30/05/2016 22:52, Mark Sheppard wrote: Hi Chris, this looks good ... so the server now listens on wildcard and the client uses IPv6 loopback as the destination address. The use of NO_PROXY, is good. I wouldn't have thought of that, and in