Re: Preliminary RFR JDK-8159053: Improve onPing/onClose behavior

Hi, On Wed, Jul 13, 2016 at 9:27 PM, Pavel Rappo wrote: > The rationale for IAE is that it's a programming error to stick an illegal > value > in a method (given the fact the value is illegal is known a priori.) We agree on the programming error, not on how to report it. Just because it's a pro

Re: Help needed: Java Socket and close detection

Christoph, My $0.2 Typically you see RST packet when the data come to a *closed* socket. You shouldn't get RST if client/server communication shutdown properly. Also balancer may take a care about connection shutdown (it needs to update internal tables) so it's possible that you never get RST af

Re: Preliminary RFR JDK-8159053: Improve onPing/onClose behavior

Hi Simone, thanks for the detailed reply (as always)! > On 13 Jul 2016, at 17:07, Simone Bordet wrote: > >>* @throws IllegalArgumentException >>* if the {@code statusCode} has an illegal value, or >>* {@code reason} doesn't have an UTF-8 representation not longer >>

Re: Help needed: Java Socket and close detection

I don't think this really makes sense as a place to ask these questions, but I can probably answer them to an extent at least. When a TCP connection is closed normally, the side (we'll call it A) which initiates the close (usually by shutting down the write half of the socket) sends a FIN and

Re: Preliminary RFR JDK-8159053: Improve onPing/onClose behavior

Hi, On Wed, Jul 13, 2016 at 3:05 PM, Pavel Rappo wrote: > /** > * Sends a Close message with the given status code and the reason. > * > ... > * > * The {@code statusCode} is an integer in the range {@code 1000 <= > code > * <= 4999}. However, not all status

Help needed: Java Socket and close detection

Hi folks, I have a question to the experts - regarding an issue that was reported to me by a customer. In the customer scenario they are running a Servlet engine and the Servlet is constantly sending data to a browser client. When the browser client is closed, the server does not get a notific

Re: RFR 8022580: sun.net.ftp.impl.FtpClient.nameList(String path) handle "null" incorrectly

+1 -Chris. On 13/07/16 14:40, Daniel Fuchs wrote: On 13/07/16 13:14, Svetlana Nikandrova wrote: Chris, Daniel, thank you for your comments. Please see updated review: http://cr.openjdk.java.net/~snikandrova/8022580/webrev.04/ Hi

RE: RFR (S) JDK-8160174: java.net.NetworkInterface - fixes and improvements for network interface listing

Hi Chris, ok, here is my new version which I think is quite a nice cleanup - though probably not "S" any more: Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8160174.3/ Bug: https://bugs.openjdk.java.net/browse/JDK-8160174 I updated the bug report to list all the small things that I've fix

Re: RFR 8022580: sun.net.ftp.impl.FtpClient.nameList(String path) handle "null" incorrectly

On 13/07/16 13:14, Svetlana Nikandrova wrote: Chris, Daniel, thank you for your comments. Please see updated review: http://cr.openjdk.java.net/~snikandrova/8022580/webrev.04/ Hi Svetlana, The test looks good to me know :-) best

Re: Preliminary RFR JDK-8159053: Improve onPing/onClose behavior

It looks like we've agreed on everything except for the status codes and the spec for what WebSocket does after a CS returned from onClose completes. May I propose the following spec? /** * Receives a Close message. * ... * * A Close message consists of a status c

Re: RFR 8022580: sun.net.ftp.impl.FtpClient.nameList(String path) handle "null" incorrectly

Chris, Daniel, thank you for your comments. Please see updated review: http://cr.openjdk.java.net/~snikandrova/8022580/webrev.04/ Thank you, Svetlana On 12.07.2016 17:25, Chris Hegarty wrote: Svetlana,

Re: RFR 8151788: NullPointerException from ntlm.Client.type3

Change looks fine to me. Thanks Max > 在 2016年7月13日，14:52，Vyom Tewari 写道： > > Hi All, > > Please find the updated > webrev(http://cr.openjdk.java.net/%7Evtewari/8151788/webrev0.1/index.html). I > addressed the review comments. > > Thanks, > Vyom > > >> On Tuesday 12 July 2016 08:25 PM, Wei

Re: RFR 8144692: HttpServer API: use of non-existant method in example in package Javadoc

On 12/07/16 13:53, Vyom Tewari wrote: Hi Pavel, Thanks for review, i updated the webrev(http://cr.openjdk.java.net/~vtewari/8144692/webrev0.0/index.html ) in place. Looks fine. -Chris. Thanks, Vyom On Tuesday 12 July 201