Re: RFR 8075484:SocketInputStream.socketRead0 can hang even with soTimeout set

2016-09-05 Thread Chris Hegarty
On 05/09/16 15:37, Mark Sheppard wrote: if the desire is to avoid making double calls on gettimeofday in the NET_ReadWithTimeout's while loop for its main call flow, Yes, the desire is to make no more calls to gettimeofday, than are already done. then consider a modification to NET_Timeout

Re: RFR 8075484:SocketInputStream.socketRead0 can hang even with soTimeout set

2016-09-05 Thread Mark Sheppard
if the desire is to avoid making double calls on gettimeofday in the NET_ReadWithTimeout's while loop for its main call flow, then consider a modification to NET_Timeout and create a version int NET_TimeoutWithCurrentTime(int s, long timeout, stuct timeval * current_time) int

Re: RFR 8075484:SocketInputStream.socketRead0 can hang even with soTimeout set

2016-09-05 Thread Chris Hegarty
Vyom, >>> webrev(http://cr.openjdk.java.net/~vtewari/8075484/webrev0.1/index.html There is some concern about the potential performance effect, etc, of gettimeofday, maybe there is a way out of this. The reuse of NET_Timeout is good, but it also calls gettimeofday. It seems that a specific

RE: Ping: RFR(S): 8163181: Further improvements for Unix NetworkInterface native implementation

2016-09-05 Thread Langer, Christoph
Done: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/40c3550625a2 Thanks for review/testing. From: Langer, Christoph Sent: Freitag, 2. September 2016 16:51 To: 'Mark Sheppard' ; net-dev@openjdk.java.net Cc: 'Chris Hegarty' Subject: RE: Ping:

Re: Review request JDK-8165180: Provide a shared secret to access non-public ServerSocket constructor

2016-09-05 Thread Peter Levart
Hi Mandy, On 09/02/2016 05:30 PM, Mandy Chung wrote: Constructor::newInstance is a caller-sensitive method that performs the security check when the caller is not the same class loader as implClass’s class loader or not its ancestor. In this case the caller class is ServerSocket and its