Re: RFR 8153674: Expected SocketException not thrown when calling bind() with setReuseAddress(false)

2016-09-28 Thread Chris Hegarty
Thank you Lucy, We’ll proceed with removing the setting of SO_REUSEPORT from the MulticastSocket constructor and spec. -Chris. > On 28 Sep 2016, at 20:02, Lu, Yingqi wrote: > > Hi Vyom, > > Thank you very much checking with us. > > We agree that SO_RESUEADDR and SO_REUSEPORT behave the sam

RE: RFR 8153674: Expected SocketException not thrown when calling bind() with setReuseAddress(false)

2016-09-28 Thread Lu, Yingqi
Hi Vyom, Thank you very much checking with us. We agree that SO_RESUEADDR and SO_REUSEPORT behave the same way for MulticastSocket. There is no need to check and enable SO_REUSEPORT for this particular type of socket. SO_REUSEADDR is sufficient. Thanks, Lucy From: Vyom Tewari [mailto:vyom.tew

RFR(S): 8166850: No runtime error expected after calling NET_MapSocketOption

2016-09-28 Thread Langer, Christoph
Hi, during my work on exception sites in the JDK, I spotted another minor place that should be fixed. In the Windows native implementations of DualStackPlainDatagramSocketImpl and DualStackPlainSocketImpl, there are calls to evaluate OS API errors after unsuccessful return of NET_MapSocketOptio

RE: RFR(XS): 8166584: Remove obsolete utility function NET_ThrowSocketException in windows libnet

2016-09-28 Thread Langer, Christoph
Thanks, I pushed: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/2b5229c75e93 Best regards Christoph > -Original Message- > From: Chris Hegarty [mailto:chris.hega...@oracle.com] > Sent: Dienstag, 27. September 2016 21:24 > To: Langer, Christoph > Cc: net-dev@openjdk.java.net > Subject: Re:

Re: RFR 8153674: Expected SocketException not thrown when calling bind() with setReuseAddress(false)

2016-09-28 Thread Chris Hegarty
Thanks Vyom, On 28/09/16 09:25, Vyom Tewari wrote: Hi All, I had off line discussion here at Oracle and we decided not to override getReuseAddr/setReuseAddr for MulticastSocket. If user wants, he can set the SO_REUSEPORT with "setOption"before bind. Right. All options that we looked at seem

Re: RFR 8153674: Expected SocketException not thrown when calling bind() with setReuseAddress(false)

2016-09-28 Thread Vyom Tewari
Hi All, I had off line discussion here at Oracle and we decided not to override getReuseAddr/setReuseAddr for MulticastSocket. If user wants, he can set the SO_REUSEPORT with "setOption"before bind. For MulticastSocket SO_REUSEADDR&SO_REUSEPORT are semantically equivalent which means either