Re: RFR(S): 8173475 : java/net/HttpURLConnection/SetAuthenticator tests have undeclared dependency on java.logging module

2017-01-31 Thread Daniel Fuchs
+1 best regards, -- daniel On 27/01/17 12:43, Sergei Kovalev wrote: Hi All, Please review a small fix for tests. BugID: https://bugs.openjdk.java.net/browse/JDK-8173475 WebRev: http://cr.openjdk.java.net/~skovalev/8173475/webrev.00/ Issue: Two tests fail in case of usage '--limit-module' co

RE: RFR:8170868: DefaultProxySelector should use system defaults on Windows, MacOS and Gnome

2017-01-31 Thread Zeller, Arno
Hi Chris, thanks for all the improvements. I imported your webrev and prepared another webrev: http://cr.openjdk.java.net/~clanger/webrevs/8170868.6/ I have seen the multiple DIRECTs myself during testing and I think filtering on the java side is a very elegant solution. Thanks for this! Best

Re: RFR:8170868: DefaultProxySelector should use system defaults on Windows, MacOS and Gnome

2017-01-31 Thread Chris Hegarty
Arno, Thanks for doing this, and your patience so far. One more final round of comments from me. Mostly minor. I’ve put them in the form of a webrev so you can easily view and import them, if you agree. http://cr.openjdk.java.net/~chegar/8170868_additional/ 1) A few comment rewordings and for

RE: RFR:8170868: DefaultProxySelector should use system defaults on Windows, MacOS and Gnome

2017-01-31 Thread Zeller, Arno
Hi Chris, thanks a lot - I did not see this case in my tests. I added your change to my new webrev: http://cr.openjdk.java.net/~clanger/webrevs/8170868.5/ Best regards, Arno >-Original Message- >From: Chris Hegarty [mailto:chris.hega...@oracle.com] >Sent: Montag, 30. Januar 2017 17:14