Chris,
On HttpRequest.
While everything is functioning as expected, it may be possible to clean up
the HttpRequest instances built through the builder, making it easier to
reason about the code.
It seems like a straight forward change to have WebSocket use an internal
API to create its requests.
Chris,
On HttpHeaders, I'll reply to your comments on HttpResponse separately.
Given the long thread, I'll try to summarize here rather and answering
specific comments inline, but I have read and attempted to address each
of them.
As you have correctly observed, the current implementation works
Alan,
On 25/05/18 12:27, Alan Bateman wrote:
On 24/05/2018 21:57, Ivan Gerasimov wrote:
..
WEBREV: http://cr.openjdk.java.net/~igerasim/8203369/00/webrev/
The changes in 01/webrev look okay to me but I'm curious if there are
any ports in OpenJDK where the values are different.
HPUX 11.31 (
On 24/05/2018 21:57, Ivan Gerasimov wrote:
Hello!
On Unix systems several system calls (including pread, read, readv,
recvfrom, recvmsg, send, sendfile, sendmsg, sendto) may set errno to
either EAGAIN or EWOULDBLOCK on the same condition.
On Linux these two constants are the same, but they a