Re: RFR [12] 8218546 : Unable to connect to https://google.com using java.net.HttpClient

Thanks for that Chris! That's so much better than what I suggested. Reviewed. -- daniel On 07/02/2019 15:08, Chris Hegarty wrote: Thanks for the comments Daniel. I made some simplifications to the test and it now covers the small missing case and is more readable. Updated webrev: http://c

Re: RFR [12] 8218546 : Unable to connect to https://google.com using java.net.HttpClient

Thanks for the comments Daniel. I made some simplifications to the test and it now covers the small missing case and is more readable. Updated webrev: http://cr.openjdk.java.net/~chegar/8218546/webrev.01/ -Chris. > On 7 Feb 2019, at 13:22, Daniel Fuchs wrote: > > Hi Chris, > > The code cha

[13] RFR: 8218554: HttpServer: allow custom handlers to request that the connection be closed after the exchange.

Hi, Please find below a fix for an HttpServer RFE: 8218554: HttpServer: allow custom handlers to request that the connection be closed after the exchange. https://bugs.openjdk.java.net/browse/JDK-8218554 webrev: http://cr.openjdk.java.net/~dfuchs/webrev_8218554/webrev.00 The code chan

Re: RFR [12] 8218546 : Unable to connect to https://google.com using java.net.HttpClient

Hi Chris, The code changes look good to me. They are very limited and look safe and reasonable. The test looks good too - though it's becoming a bit more difficult to read, especially with the mysterious i > 0. I'd suggest adding a comment (or some asserts) in the else branch of the if (lines 2

RFR [12] 8218546 : Unable to connect to https://google.com using java.net.HttpClient

This is a code review request for a late fix for JDK 12, to address a potentially serious regression. Post 8213189 [1] the HTTP Client now adds both the `:authority:` pseudo-header and the `Host` header to outbound HTTP/2 requests. The HTTP/2 RFC does not seem to rule out this behavior, but it doe

Re: Question about com.sun.net.httpserver.HttpExchange#sendResponseHeaders

Hi Wenbo, On 06/02/2019 23:21, Wenbo Zhu wrote: Thanks! The text looks good. p.s. is there a way I could get notified of any future updates on this issue? I had thought that I have a java.net account ... If you have the OpenJDK author status you should have the ability to l