Re: RFR: JDK-8184770: JDWP support for IPv6

2019-04-01 Thread Alex Menkov
Hi Daniel, As far as I see you are right. Attach to address with empty hostname will try to connect to "external" address instead of loopback. --alex On 04/01/2019 02:51, Daniel Fuchs wrote: Hi Arthur, Not directly related to Alex's original question but... On 30/03/2019 00:03, Arthur Euba

Re: [ipv6] Regarding 8220673: Add test library support for determining platform IP support

2019-04-01 Thread Arthur Eubanks
There are a bunch of tests with "-Djava.net.preferIPv4Stack=true", which should clearly fail in an IPv6 only environment. Would skipping these when IPv4 is not supported be okay? I see that some tests with "-Djava.net.preferIPv6Addresses=true" will pass even if the IPv6 part of the test failed. O

Re: RFR: JDK-8184770: JDWP support for IPv6

2019-04-01 Thread Alex Menkov
On 04/01/2019 05:02, Chris Hegarty wrote: On 01/04/2019 12:50, Chris Hegarty wrote: ... Specifically on SocketTransportService.java. What Arthur has proposed is better ( changing to lastIndexOf alone is not sufficient ). Or is your assumption that the IPv6 literal is not enclosed in square b

Re: RFR: JDK-8184770: JDWP support for IPv6

2019-04-01 Thread Alex Menkov
Hi Chris, On 04/01/2019 04:50, Chris Hegarty wrote: Alex, On 29/03/2019 22:07, Alex Menkov wrote: (added net-dev as suggested by Alan) Net gurus, please assist in reviewing socket-related code. New webrev: http://cr.openjdk.java.net/~amenkov/IPv6/webrev.01/ Specifically on SocketTransportS

Re: RFR: JDK-8184770: JDWP support for IPv6

2019-04-01 Thread Alex Menkov
Hi Daniel, Chris, Unfortunately docs are out-dated (I plan to update it in JDK13). In JDK9 https://bugs.openjdk.java.net/browse/JDK-8041435 changed the behavior - empty address (i.e. only port is specified) means "local connections only", "*" means "all available connections". Then in JDK10 new

Re: [ipv6] Issue Tracking

2019-04-01 Thread Martin Buchholz
Sorry for never having had the time to finish https://bugs.openjdk.java.net/browse/JDK-8179037 Improve IPv6 support On Mon, Apr 1, 2019 at 6:12 AM Chris Hegarty wrote: > Arthur, others, > > In order to help track the all the IPv6 related work, we have the > following issues: > > Improved IPv6 Su

Re: [ipv6] Issue Tracking

2019-04-01 Thread Arthur Eubanks
Sounds good, thanks. On Mon, Apr 1, 2019 at 6:11 AM Chris Hegarty wrote: > Arthur, others, > > In order to help track the all the IPv6 related work, we have the > following issues: > > Improved IPv6 Support ( for implementation issues ) >https://bugs.openjdk.java.net/browse/JDK-8221681 > > U

Re: RFR: JDK-8184770: JDWP support for IPv6

2019-04-01 Thread Chris Hegarty
On 01/04/2019 10:51, Daniel Fuchs wrote: Hi Arthur, Not directly related to Alex's original question but... On 30/03/2019 00:03, Arthur Eubanks wrote: We have some ipv6 patches as well in this area as well (as well as other patches to support ipv6 only environments) that we're trying to ups

[ipv6] Issue Tracking

2019-04-01 Thread Chris Hegarty
Arthur, others, In order to help track the all the IPv6 related work, we have the following issues: Improved IPv6 Support ( for implementation issues ) https://bugs.openjdk.java.net/browse/JDK-8221681 Update JDK networking tests for IPv6-only environments ( test-only ) https://bugs.openjdk.

Re: RFR: JDK-8184770: JDWP support for IPv6

2019-04-01 Thread Chris Hegarty
On 01/04/2019 12:50, Chris Hegarty wrote: ... Specifically on SocketTransportService.java. What Arthur has proposed is better ( changing to lastIndexOf alone is not sufficient ). Or is your assumption that the IPv6 literal is not enclosed in square brackets? More specifically, what syntax ar

Re: RFR: JDK-8184770: JDWP support for IPv6

2019-04-01 Thread Chris Hegarty
Alex, On 29/03/2019 22:07, Alex Menkov wrote: (added net-dev as suggested by Alan) Net gurus, please assist in reviewing socket-related code. New webrev: http://cr.openjdk.java.net/~amenkov/IPv6/webrev.01/ Specifically on SocketTransportService.java. What Arthur has proposed is better ( chan

Re: RFR: JDK-8184770: JDWP support for IPv6

2019-04-01 Thread Daniel Fuchs
Hi Arthur, Not directly related to Alex's original question but... On 30/03/2019 00:03, Arthur Eubanks wrote: We have some ipv6 patches as well in this area as well (as well as other patches to support ipv6 only environments) that we're trying to upstream. I don't understand the code myself, b