Re: [RFR]: 8222562: IPv6 only systems fail on setsockopt(IPV6_V6ONLY, 0)

2019-04-17 Thread Arthur Eubanks
It turns out these patches only apply to a modified kernel which has patches to turn off IPv4. This specific patch doesn't make sense to submit if the kernel patches are not upstream. Maybe the entire call to setsockopt(IPV6_V6ONLY, 0) could be skipped if IPv4 is disabled. I'll look into Daniel's

Re: RFR: 8222527: HttpClient doesn't send HOST header when tunelling HTTP/1.1 through http proxy

2019-04-17 Thread Daniel Fuchs
Hi Michael, On 17/04/2019 17:06, Michael McMahon wrote: Looks fine. Though is the HOST_ALLOWED predicate actually needed in Utils.java? Can you not do the negation inline directly in the HOST_RESTRICTED predicate? Good point! http://cr.openjdk.java.net/~dfuchs/webrev_8222527/webrev.01 best

Re: RFR: 8222527: HttpClient doesn't send HOST header when tunelling HTTP/1.1 through http proxy

2019-04-17 Thread Michael McMahon
Hi Daniel, Looks fine. Though is the HOST_ALLOWED predicate actually needed in Utils.java? Can you not do the negation inline directly in the HOST_RESTRICTED predicate? - Michael. On 17/04/2019, 16:13, Daniel Fuchs wrote: Hi, Please find below a fix for: Issue: 8222527: HttpClient doesn't

Re: [ipv6] Issue Tracking

2019-04-17 Thread Chris Hegarty
Paul, On 17/04/2019 01:26, Paul Marks wrote: On Mon, Apr 1, 2019 at 9:38 AM Martin Buchholz > wrote: Sorry for never having had the time to finish https://bugs.openjdk.java.net/browse/JDK-8179037 Improve IPv6 support I think https://bugs.openjdk.java.ne

RFR: 8222527: HttpClient doesn't send HOST header when tunelling HTTP/1.1 through http proxy

2019-04-17 Thread Daniel Fuchs
Hi, Please find below a fix for: Issue: 8222527: HttpClient doesn't send HOST header when tunnelling HTTP/1.1 through http proxy https://bugs.openjdk.java.net/browse/JDK-8222527 webrev: http://cr.openjdk.java.net/~dfuchs/webrev_8222527/webrev.00 When sending the internal CONNECT reque

Re: How to deal with multi-step WWW-Authenticate with the new HttpClient

2019-04-17 Thread Chris Hegarty
Thank you for following up with the resolution, Max. -Chris. On 17/04/2019 14:24, Weijun Wang wrote: Sorry, after adding "-Djdk.httpclient.HttpClient.log=headers,errors,channel" I found out it's my problem. On Apr 17, 2019, at 11:09 AM, Weijun Wang wrote: Hi, All, I am trying the new Http

Re: [RFR]: 8222562: IPv6 only systems fail on setsockopt(IPV6_V6ONLY, 0)

2019-04-17 Thread Chris Hegarty
Arthur, On 16/04/2019 22:34, Arthur Eubanks wrote: Hi, Copied from the bug https://bugs.openjdk.java.net/browse/JDK-8222562: Some of the networking code tries to support dual socket support. However, it doesn't work with IPv6 only systems. setsockopt(fd, IPPROTO_IPV6, IPV6_V6ONLY, 0) returns

Re: How to deal with multi-step WWW-Authenticate with the new HttpClient

2019-04-17 Thread Weijun Wang
Sorry, after adding "-Djdk.httpclient.HttpClient.log=headers,errors,channel" I found out it's my problem. > On Apr 17, 2019, at 11:09 AM, Weijun Wang wrote: > > Hi, All, > > I am trying the new HttpClient to deal with a multi-step Negotiate > authentication with Windows IIS, and here is my co

Re: [RFR]: 8222562: IPv6 only systems fail on setsockopt(IPV6_V6ONLY, 0)

2019-04-17 Thread Daniel Fuchs
Hi Arthur, On 17/04/2019 07:54, Alan Bateman wrote: On 16/04/2019 22:34, Arthur Eubanks wrote: Hi, Copied from the bug https://bugs.openjdk.java.net/browse/JDK-8222562: Some of the networking code tries to support dual socket support. However, it doesn't work with IPv6 only systems. setsock