Hi Serguei,
updated webrev:
http://cr.openjdk.java.net/~amenkov/IPv6/webrev.04/
Fixed everything except #7 (for consistency - in the file if function
arguments spread on several lines, opening curly bracket is placed to
separate line to separate function declaration from the function body).
On 23/04/2019 16:54, Arthur Eubanks wrote:
I believe that `DONT_ENABLE_IPV4`is not strictly required. Maybe just
drop it? Is it an initial attempt to support an IPv6-only JDK build?
If so, then maybe we separate out that requirement.
It was in the IPv6 code right below so I just
Arthur,
Some time ago Chris mentioned [1] that there was at least one test failing due
to missing SANs in its certificates:
test/jdk/sun/net/www/protocol/https/HttpsURLConnection/IPAddressIPIdentities.java
You then replied that your were planning to address that issue in a future
change.
I
Arthur,
On 23/04/2019 11:20, Chris Hegarty wrote:
Arthur,
On 22/04/2019 19:19, Arthur Eubanks wrote:
Here's a new webrev that entirely skips the setting of IPV6_V6ONLY
option to 0 if IPv4 isn't enabled.
http://cr.openjdk.java.net/~aeubanks/ipv6setsockopt/webrev.01/index.html
This looks rea
Arthur,
On 22/04/2019 19:19, Arthur Eubanks wrote:
Here's a new webrev that entirely skips the setting of IPV6_V6ONLY
option to 0 if IPv4 isn't enabled.
http://cr.openjdk.java.net/~aeubanks/ipv6setsockopt/webrev.01/index.html
This looks reasonable to me.
-Chris.
