Re: RFR: 8223145: [teststabilization] Replace wildcard address with loopback or local host in test - part 1

2019-04-30 Thread mark sheppard
​ Hi Daniel,​ ​ interesting set of changes -​ But could it be the case that, for some tests, you might change the operational semantics of a test, when​ this applying this change. For example, in the case of GetLocalAddress.​ The original is to use a wild card for the server, and a directed addre

RFR: 8217364: Custom URLStreamHandler for jrt or file protocol can override default handler

2019-04-30 Thread Seán Coffey
Looking to correct an issue that arose during the JDK-8213942 fix. https://bugs.openjdk.java.net/browse/JDK-8217364 https://cr.openjdk.java.net/~coffeys/webrev.8217364/webrev/ regards, Sean.

Re: RFR 8216978: Drop support for pre JDK 1.4 SocketImpl implementations

2019-04-30 Thread Daniel Fuchs
On 30/04/2019 10:53, Michael McMahon wrote: Thanks for all the comments. A new webrev is at: http://cr.openjdk.java.net/~michaelm/8216978/webrev.2/index.html Looks good Michael! cheers, -- daniel

RFR: 8223145: [teststabilization] Replace wildcard address with loopback or local host in test - part 1

2019-04-30 Thread Daniel Fuchs
Hi, Please find below a patch for: 8223145: [teststabilization] Replace wildcard address with loopback or local host in test - part 1 https://bugs.openjdk.java.net/browse/JDK-8223145 http://cr.openjdk.java.net/~dfuchs/webrev_8223145/webrev.00/ This is the first in a series of patches

Re: RFR 8216978: Drop support for pre JDK 1.4 SocketImpl implementations

2019-04-30 Thread Chris Hegarty
> On 30 Apr 2019, at 10:53, Michael McMahon > wrote: > > Thanks for all the comments. A new webrev is at: > > http://cr.openjdk.java.net/~michaelm/8216978/webrev.2/index.html Looks good. -Chris.

Re: RFR 8216978: Drop support for pre JDK 1.4 SocketImpl implementations

2019-04-30 Thread Alan Bateman
On 30/04/2019 10:53, Michael McMahon wrote: Thanks for all the comments. A new webrev is at: http://cr.openjdk.java.net/~michaelm/8216978/webrev.2/index.html The CSR now also includes the minor API doc update suggested for the no-arg SocketImpl constructor. This looks okay to me. -Alan

Re: RFR 8216978: Drop support for pre JDK 1.4 SocketImpl implementations

2019-04-30 Thread Michael McMahon
Thanks for all the comments. A new webrev is at: http://cr.openjdk.java.net/~michaelm/8216978/webrev.2/index.html The CSR now also includes the minor API doc update suggested for the no-arg SocketImpl constructor. Thanks, Michael On 29/04/2019, 10:52, Michael McMahon wrote: Hi, This is ano