On 08/05/2019 18:24, Daniel Fuchs wrote:
Hi,
Please find below another patch in the series for intermittently
failing tests:
8223573: Replace wildcard address with loopback or local host in
tests - part 4
https://bugs.openjdk.java.net/browse/JDK-8223573
patch:
http://cr.openjdk.java.n
On 09/05/2019 08:09, Alan Bateman wrote:
http://cr.openjdk.java.net/~dfuchs/webrev_8223573/webrev.00/
I skimmed through the diffs and they look okay with me. Minor nit in
6550798/test.java is there is a space in "HttpServer.create (". Also
wonder if we should rename this source file too.
Than
Daniel,
> On 9 May 2019, at 10:21, Daniel Fuchs wrote:
>
> ...
> Meanwhile I also found two other tests that needed updating:
> test/jdk/sun/net/www/http/ChunkedInputStream/ChunkedEncodingWithProgressMonitorTest.java
> test/jdk/sun/net/www/http/ChunkedInputStream/TestAvailable.java
>
> I've add
Hi Chris,
On 09/05/2019 10:33, Chris Hegarty wrote:
http://cr.openjdk.java.net/~dfuchs/webrev_8223573/webrev.01/
Looks good.
I’m missing why ChunkedEncodingWithProgressMonitorTest.java
needs `@library /test/lib` added?
It depends on ChunkedInputStream/ChunkedEncodingTest.java, creates
an ins
On 09/05/2019 10:21, Daniel Fuchs wrote:
On 09/05/2019 08:09, Alan Bateman wrote:
http://cr.openjdk.java.net/~dfuchs/webrev_8223573/webrev.00/
I skimmed through the diffs and they look okay with me. Minor nit in
6550798/test.java is there is a space in "HttpServer.create (". Also
wonder if we
On 09/05/2019 10:52, Alan Bateman wrote:
Thanks, I see there is no more at L48 (you've removed one of them but
there is a second).
In any case, the updated webrev looks good.
Argh! Thanks Alan - well spotted. I'll remove the offending
space before pushing.
best regards,
-- daniel
On 07/05/2019, 17:14, Alan Bateman wrote:
On 07/05/2019 16:44, Michael McMahon wrote:
Hi Alan,
What's the purpose of the change to the UdpTest?
The deprecated Socket constructors can be used to create a Socket that
uses UDP. This means the new SocketImpl has to support the creation of
UDP
Alan,
> On 9 May 2019, at 07:22, Alan Bateman wrote:
>
> On 08/05/2019 12:02, Chris Hegarty wrote:
>> :
>>>
>>> New webrev: http://cr.openjdk.java.net/~aeubanks/8220673/webrev.03/
>>
>> :
>>
>> P.S. adding nio-dev since there are a few tests in that area
>> being updated.
> Thanks for forward
On 09/05/2019 11:51, Michael McMahon wrote:
Ok, thanks. A test that might be useful could be one that compares the
supported options between the old
and new impls for both client and server sockets. I guess it shouldn't
be required for the initial push though.
There are several existing tests
On 09/05/2019 12:02, Chris Hegarty wrote:
:
I agree that the method name could be improved. It’s really:
“skip test if cannot create a minimally-operational IPv4 or IPv6 socket"
Some concrete method name suggestions ( more welcome ):
- IPSupport::skipTestIfNonOperational
- IPSupport::ski
Hi Arthur et al.
with these changes and the increased separation of IPv4 and IPv6 in the
call flows, does
it make sense to preclude the retrieval of IPv6 interfaces, if there is an
error in the IPv4 processing in the
enumInterfaces function ? Or that an error retrieving IPv6 interfaces
pr
Thanks Chris and Michael for the reviews/help so far. I've uploaded a
new webrev to address most of their points here:
http://cr.openjdk.java.net/~alanb/8221481/2/webrev/index.html
and delta webrev with the changes from 1 to 2 here:
http://cr.openjdk.java.net/~alanb/8221481/1to2/webrev/ind
Alan,
> On 9 May 2019, at 14:00, Alan Bateman wrote:
>
> Thanks Chris and Michael for the reviews/help so far. I've uploaded a new
> webrev to address most of their points here:
>http://cr.openjdk.java.net/~alanb/8221481/2/webrev/index.html
>
> and delta webrev with the changes from 1 to 2
Looks good to me. I don't have anything else to add at this point. I
agree the new implementation is much clearer
than the old and it will be great to see it working in the field.
Thanks,
Michael
On 09/05/2019, 14:00, Alan Bateman wrote:
Thanks Chris and Michael for the reviews/help so far. I'
Hi Christoph,
I'm only commenting on the HttpClient changes, I'll let
others comment on the other changes...
http://cr.openjdk.java.net/~clanger/webrevs/8223553.0/src/java.net.http/share/classes/jdk/internal/net/http/ExchangeImpl.java.udiff.html
I have a profound dislike for using @SuppressedWa
Arthur,
> On 8 May 2019, at 18:33, Arthur Eubanks wrote:
>
> Reverted changes in net_util.c.
> Also, webrev.00 would create an IPv6 socket even if creating the IPv4 socket
> was successful. Fixed. (My very first revision had this same issue, which I
> thought I had fixed before sending it out.
Hi Arthur,
Looks good to me.
best regards,
-- daniel
On 09/05/2019 18:40, Arthur Eubanks wrote:
Bug: https://bugs.openjdk.java.net/browse/JDK-8223652
Webrev: http://cr.openjdk.java.net/~aeubanks/8223652/webrev.00/index.html
As mentioned in
https://markmail.org/search/?q=aeubanks%40google.co
Hi,
Please help to review another part of test fixes to address intermittent
failures.
Webrev:
http://cr.openjdk.java.net/~aefimov/8223465/00/
JBS:
https://bugs.openjdk.java.net/browse/JDK-8223465
With Best Regards,
Aleksei
18 matches
Mail list logo
