Re: [ipv6] RFR: 8224256: test/jdk/java/security/SecureClassLoader/DefineClass.java hardcodes 127.0.0.1

On 5/22/19 3:33 PM, Arthur Eubanks wrote: On Wed, May 22, 2019 at 12:12 PM Sean Mullan > wrote: On 5/22/19 1:28 PM, Arthur Eubanks wrote: > On Wed, May 22, 2019 at 7:13 AM Daniel Fuchs mailto:daniel.fu...@oracle.com> >

Re: [ipv6] RFR: 8224256: test/jdk/java/security/SecureClassLoader/DefineClass.java hardcodes 127.0.0.1

On 5/22/19 1:28 PM, Arthur Eubanks wrote: On Wed, May 22, 2019 at 7:13 AM Daniel Fuchs > wrote: Hi Arthur,    18 // For IPSupport    19 grant {    20     permission java.net.SocketPermission "localhost:0", "listen,resolve";    21     p

Re: [ipv6] RFR: 8224256: test/jdk/java/security/SecureClassLoader/DefineClass.java hardcodes 127.0.0.1

Hi Arthur, On 22/05/2019 18:28, Arthur Eubanks wrote: New webrev: http://cr.openjdk.java.net/~aeubanks/8224256/webrev.01/ Looks good to me - please just get someone from security-dev to review too. best regards, -- daniel

[teststabilization] RFR: 8224603: Replace wildcard address with loopback or local host in tests - part 11

Hi, Please find below a patch for the next batch of tests that have been observed failing intermittently. JBS: https://bugs.openjdk.java.net/browse/JDK-8224603 webrev: http://cr.openjdk.java.net/~dfuchs/webrev_8224603/webrev.00/ One of them has just acquired a /othervm keyword: it is setting a

Re: [ipv6] RFR: 8224256: test/jdk/java/security/SecureClassLoader/DefineClass.java hardcodes 127.0.0.1

Hi Arthur, [adding security-dev] 18 // For IPSupport 19 grant { 20 permission java.net.SocketPermission "localhost:0", "listen,resolve"; 21 permission java.util.PropertyPermission "java.net.preferIPv4Stack", "read"; 22 }; It might be better if these permissions were granted

Re: [ipv6] RFR: 8224256: test/jdk/java/security/SecureClassLoader/DefineClass.java hardcodes 127.0.0.1

Hi Arthur, 18 // For IPSupport 19 grant { 20 permission java.net.SocketPermission "localhost:0", "listen,resolve"; 21 permission java.util.PropertyPermission "java.net.preferIPv4Stack", "read"; 22 }; It might be better if these permissions were granted to the library only.

Re: [ipv6] RFR: 8224256: test/jdk/java/security/SecureClassLoader/DefineClass.java hardcodes 127.0.0.1

Arthur, > On 21 May 2019, at 00:50, Arthur Eubanks > wrote: > > bug: https://bugs.openjdk.java.net/browse/JDK-8224256 > webrev: > http://cr.openjdk.java.net/~aeubanks/8224256/webrev.00/index.html >

Re: [ipv6] RFR: 8224256: test/jdk/java/security/SecureClassLoader/DefineClass.java hardcodes 127.0.0.1

Arthur, > On 21 May 2019, at 00:50, Arthur Eubanks > wrote: > > bug: https://bugs.openjdk.java.net/browse/JDK-8224256 > webrev: > http://cr.openjdk.java.net/~aeubanks/8224256/webrev.00/index.html >

Re: [ipv6] RFR: 8224248: test/jdk/java/net/InetAddress/CheckJNI.java assumes 127.0.0.1 is available

Arthur, > On 20 May 2019, at 22:30, Arthur Eubanks wrote: > > bug: https://bugs.openjdk.java.net/browse/JDK-8224248 > webrev: > http://cr.openjdk.java.net/~aeubanks/8224248/webrev.00/ >

Re: RFR 8224477 [13] java.net.Socket::setOption - implementation mismatch to spec

Alan, > On 21 May 2019, at 20:05, Alan Bateman wrote: > > On 21/05/2019 19:36, Chris Hegarty wrote: >> The get/setOption methods of java.net Socket, ServerSocket, and >> DatagramSocket, are specified to throw NullPointerException if the given >> option name is null ( rather than UnsupportedOpera

Re: [teststabilization] RFR: 8224204: Replace wildcard address with loopback or local host in tests - part 10

> On 21 May 2019, at 18:25, Daniel Fuchs wrote: > > Hi, > > Please find below a patch for: > > 8224204: Replace wildcard address with loopback or local host in > tests - part 10 > https://bugs.openjdk.java.net/browse/JDK-8224204 > > which fixes a bunch of sun/net/* tests that were ob

Re: [ipv6] RFR: 8224248: test/jdk/java/net/InetAddress/CheckJNI.java assumes 127.0.0.1 is available

Hi Arthur, This looks good to me. BTW: I sent your patch through our test system and didn't see any failures. Reviewed! best regards, -- daniel On 20/05/2019 22:30, Arthur Eubanks wrote: bug: https://bugs.openjdk.java.net/browse/JDK-8224248 webrev: http://cr.openjdk.java.net/~aeubanks/82242