Re: [BUG] Inet6Address.isIPv4CompatibleAddress uses wrong prefix

2019-06-24 Thread Alan Bateman
On 24/06/2019 21:57, Rob Spoor wrote: I found a bug in Inet6Adress.isIPv4CompatibleAddress(). While parsing correctly uses the ::: format, isIPv4CompatibleAddress() checks for :: instead. The notion "IPv4-compatible IPv6 address" is different to "IPv4-mapped IPv6 address".  I think the RFCs

RE: [BUG] Inet6Address.isIPv4CompatibleAddress uses wrong prefix

2019-06-24 Thread Langer, Christoph
Hi Rob, sending this over to net-dev, where it should be discussed... /Christoph > -Original Message- > From: core-libs-dev On Behalf > Of Rob Spoor > Sent: Montag, 24. Juni 2019 22:58 > To: core-libs-...@openjdk.java.net > Subject: [BUG] Inet6Address.isIPv4CompatibleAddress uses wrong

Re: RFR: 8219804 ava/net/MulticastSocket/Promiscuous.java fails intermittently due to NumberFormatException

2019-06-24 Thread Michael McMahon
On 24/06/2019, 11:31, Michael McMahon wrote: Hi Mark On 23/06/2019, 13:53, mark sheppard wrote: : ​ Since the socket is receiving something unexpected, I think I agree that binding to the multicast address could be worth doing as well. That would filter out packets that perhaps broadcast o

RFR [14] 8226303: Test convenience reactive primitives from java.net.http with RS TCK

2019-06-24 Thread Pavel Rappo
Hello, Please review the following change: http://cr.openjdk.java.net/~prappo/8226602/webrev.00/ This change adds reactive streams conformance testing of convenience primitives exposed by java.net.http.HttpClient. The TckDriver.java file from the webrev provides some explanation on the gener

Re: RFR: 8219804 ava/net/MulticastSocket/Promiscuous.java fails intermittently due to NumberFormatException

2019-06-24 Thread Michael McMahon
Hi Daniel, On 21/06/2019, 17:54, Daniel Fuchs wrote: Hi Michael, Thanks for doing that. IT should make this test much more stable. On 21/06/2019 17:27, Michael McMahon wrote: There is a nio test, java/nio/channels/DatagramChannel/Promiscuous.java that follows a similar pattern. Should it be u

Re: RFR: 8219804 ava/net/MulticastSocket/Promiscuous.java fails intermittently due to NumberFormatException

2019-06-24 Thread Michael McMahon
Hi Mark On 23/06/2019, 13:53, mark sheppard wrote: Hi Michael, Chris, a brief note on the possibility of stray packets.​ For the test to receive data from external sources it would be necessary that the senders are​ using the same port ( as well as the mcast address) as your test (which