Re: RFR: 8230000: some httpclients testng tests run zero test

Oh! Good catch Aleksei! In fact all three files are missing the comma. cheers, -- daniel On 23/08/2019 18:47, Aleks Efimov wrote: Hi Julia, Minor comments: test/jdk/java/net/httpclient/LineStreamsAndSurrogatesTest.java#2: Could you please add the missing comma after the last modification yea

Re: RFR: 8230000: some httpclients testng tests run zero test

Hi Julia, Minor comments: test/jdk/java/net/httpclient/LineStreamsAndSurrogatesTest.java#2: Could you please add the missing comma after the last modification year, i.e. "2018, 2019," test/jdk/java/net/httpclient/LineSubscribersAndSurrogatesTest.java#2: Same stuff: "2018, 2019," Otherwise loo

Re: RFR: 8230000: some httpclients testng tests run zero test

Hi Julia, Looks good to me too! I will sponsor your change. best regards, -- daniel On 23/08/2019 17:16, Julia Boes wrote: Hi, Please find below a fix of three httpclient tests for which testng trivially passed without running any tests. In LineSubscribersAndSurrogatesTest and LineStreams

Re: RFR: 8230000: some httpclients testng tests run zero test

> On 23 Aug 2019, at 17:16, Julia Boes wrote: > …. > > Bug: https://bugs.openjdk.java.net/browse/JDK-823 > > Webrev: http://cr.openjdk.java.net/~dfuchs/jboes/823/webrev.01/ LGTM. -Chris.

RFR: 8230000: some httpclients testng tests run zero test

Hi, Please find below a fix of three httpclient tests for which testng trivially passed without running any tests. In LineSubscribersAndSurrogatesTest and LineStreamsAndSurrogatesTest, the access modifier of the methods in question was changed to public. For AbstractThrowingPushPromises, th

Re: RFR [8193596]: java/net/DatagramPacket/ReuseBuf.java failed due to timeout

Hi Alan, On 23/08/2019 10:25, Alan Bateman wrote: On 23/08/2019 10:10, Patrick Concannon wrote: Hi, Would it be possible to have my fix for JDK-8193596 reviewed? The test fails intermittently due to binding to wildcard addresses -- similar to those that have been fixed under the umbrella of

Re: RFR [8193596]: java/net/DatagramPacket/ReuseBuf.java failed due to timeout

On 23/08/2019 10:10, Patrick Concannon wrote: Hi, Would it be possible to have my fix for JDK-8193596 reviewed? The test fails intermittently due to binding to wildcard addresses -- similar to those that have been fixed under the umbrella of JDK-8222938

RFR [8193596]: java/net/DatagramPacket/ReuseBuf.java failed due to timeout

Hi, Would it be possible to have my fix for JDK-8193596 reviewed? The test fails intermittently due to binding to wildcard addresses -- similar to those that have been fixed under the umbrella of JDK-8222938 . This fix changes the binding fro