Re: RFR: 8231260: (dc) DatagramChannel::disconnect changes the port of the local address to 0 (lnx)

2019-10-07 Thread mark sheppard
Hi Daniel, wrt impl note ... would some explanation on the esoteric reason for a now possible BindException be useful, also? namely that on some platforms the socket is unbound during the disconnect and requires a re-bind, which for ephemeral ports allocated may result in a BindException.

Re: RFR: 8231260: (dc) DatagramChannel::disconnect changes the port of the local address to 0 (lnx)

2019-10-07 Thread Florian Weimer
* Daniel Fuchs: > Here is the new webrev - I believe I have addressed all your comments: > > http://cr.openjdk.java.net/~dfuchs/webrev_8231260/webrev.01 Looks good to me too. Sorry for the distraction earlier. Thanks, Florian

Re: RFR: 8231260: (dc) DatagramChannel::disconnect changes the port of the local address to 0 (lnx)

2019-10-07 Thread Chris Hegarty
> On 7 Oct 2019, at 12:34, Daniel Fuchs wrote: > > Hi Alan, > > Here is the new webrev - I believe I have addressed all your comments: > > http://cr.openjdk.java.net/~dfuchs/webrev_8231260/webrev.01 Looks good Daniel. -Chris

Re: RFR: 8231260: (dc) DatagramChannel::disconnect changes the port of the local address to 0 (lnx)

2019-10-07 Thread Alan Bateman
On 07/10/2019 12:34, Daniel Fuchs wrote: Hi Alan, Here is the new webrev - I believe I have addressed all your comments: http://cr.openjdk.java.net/~dfuchs/webrev_8231260/webrev.01 Thanks for the update, this version looks good to me. -Alan.

Re: RFR: 8231260: (dc) DatagramChannel::disconnect changes the port of the local address to 0 (lnx)

2019-10-07 Thread Daniel Fuchs
Hi Alan, Here is the new webrev - I believe I have addressed all your comments: http://cr.openjdk.java.net/~dfuchs/webrev_8231260/webrev.01 best regards, -- daniel On 04/10/2019 14:55, Alan Bateman wrote: On 04/10/2019 14:34, Daniel Fuchs wrote: : webrev: