Re: RFR: 8231260: (dc) DatagramChannel::disconnect changes the port of the local address to 0 (lnx)

Hi Mark, On 09/10/2019 10:44, mark sheppard wrote: Would it be instantaneously available after its release by the kernel, or subject to TTL lifetime? The fact that DatagramSocket has been doing that for years and that we haven't had any issue so far suggests that the case where rebind would

RFR: 8225499: InetSocketAddress::toString not friendly to IPv6 literal addresses

Hi, This fix improves the handling of IPv6 addresses in InetSocketAddress::toString. The implementation now encloses the IPv6 literal in brackets, which wasn't done previously. Example: new InetSocketAddress("::1", 80).toString() before: /0:0:0:0:0:0:0:1:80 after: /[0:0:0:0:0:0:0:1]:80

Re: RFR: 8231260: (dc) DatagramChannel::disconnect changes the port of the local address to 0 (lnx)

OK Alan, Daniel thanks for the feedback and consideration … but what you say does lend an argument that localAddress = null; rather than localAddress = isa; is a reasonable value in the event of Net.bind throwing a BindException  but, as you have said, that may have other implications

Re: RFR: JDK-8214560 - Use {@systemProperty} for definitions of system properties (httpserver)

On 08/10/2019 17:19, Kiran Ravikumar wrote: Hi Guys, Could you please review this minor fix: Bug :https://bugs.openjdk.java.net/browse/JDK-8214560 Webrev :https://cr.openjdk.java.net/~coffeys/webrev.8214560/webrev/ Thanks

Re: RFR: JDK-8214560 - Use {@systemProperty} for definitions of system properties (httpserver)

Looks good Kiran. I'll sponsor this for you. regards, Sean. On 08/10/2019 17:19, Kiran Ravikumar wrote: Hi Guys, Could you please review this minor fix: Bug :https://bugs.openjdk.java.net/browse/JDK-8214560 Webrev :https://cr.openjdk.java.net/~coffeys/webrev.8214560/webrev/