RFR[8233307]: MulticastSocket getOption(IP_MULTICAST_IF) returns interface when not set

2019-11-27 Thread Patrick Concannon
Hi, Could someone please review my fix and CSR for issue JDK-8233307 'MulticastSocket getOption(IP_MULTICAST_IF) returns interface when not set'? The IP_MULTICAST_IF socket option is specified to have an initial value of null to mean that the interface has not been set. However, if

Re: RFR: 8233185: HttpServer.stop() blocks indefinitely when called on dispatch thread

2019-11-27 Thread Julia Boes
Hi, JDK8  we  don't do join() on "dispatcherThread" in stop(). We need to find out why we introduce the below code. if (dispatcherThread != null) {     try {     dispatcherThread.join();     } catch

Re: RFR: 8233185: HttpServer.stop() blocks indefinitely when called on dispatch thread

2019-11-27 Thread mark sheppard
Hello, I may have added this to fix some other issue. it would seem reasonable that stop() would reap (join) the dispatcher thread that was launched in start() What is not expected, based on the design of the Dispatcher, that a stop() will be invoked from within its executing thread (run