Hi Julia and Daniel,
I ran the test as a standalone under 8 and 13 and got the following
on windows 10
$ java -version
java version "1.8.0_231"
Java(TM) SE Runtime Environment (build 1.8.0_231-b11)
Java HotSpot(TM) 64-Bit Server VM (build 25.231-b11, mixed mode)
$ java PortUnreachableTest
Att
Forwarding to a more relevant mailing list. When answering,
please remove jdk-dev from the list of recipients.
Thanks.
> Begin forwarded message:
>
> From: Chris Mason
> Subject: HTTP/2 Support in com.sun.net.httpserver?
> Date: 4 December 2019 at 18:02:30 GMT
> To: "jdk-...@openjdk.java.net"
Hi Julia,
Looks good to me.
I wonder however if the links to the deprecated setInterface method
should remain in the two args joinGroup/leaveGroup, since the
behavior is still in effect should you call that method.
best regards
-- daniel
On 04/12/2019 16:40, Julia Boes wrote:
Hi,
Please see
Doh! My mistake. I dropped this part in the test:
http://cr.openjdk.java.net/~dfuchs/webrev_8235141/webrev.02
cheers,
-- daniel
On 04/12/2019 16:42, Chris Hegarty wrote:
Daniel,
On 04/12/2019 14:24, Daniel Fuchs wrote:
This test doesn't test NetworkChannel.
This is what I was referring to:
Julia,
On 04/12/2019 16:40, Julia Boes wrote:
Hi,
Please see this fix that deprecates methods of MulticastSocket.
These methods either operate on InetAddress instead of NetworkInterface
or work with SocketOptions.IP_MULTICAST_LOOP instead of
StandardSocketOptions.IP_MULTICAST_LOOP.
Bug: ht
Daniel,
On 04/12/2019 14:24, Daniel Fuchs wrote:
This test doesn't test NetworkChannel.
This is what I was referring to:
{ Configurable.of(SocketChannel.open()), SOCKET_OPTIONS }
..
static Configurable of(NetworkChannel
socket) {
return new ConfigurableImpl<>(socket, sock
Hi,
Please see this fix that deprecates methods of MulticastSocket.
These methods either operate on InetAddress instead of NetworkInterface
or work with SocketOptions.IP_MULTICAST_LOOP instead of
StandardSocketOptions.IP_MULTICAST_LOOP.
Bug: https://bugs.openjdk.java.net/browse/JDK-8233319
Hi Julia,
Looks good to me - but is:
31 * @library /test/lib
actually needed?
best regards,
-- daniel
On 04/12/2019 15:40, Julia Boes wrote:
Hi,
The test PortUnreachable closes a DatagramSocket and tries to rebind it
to the same port, this causes the test to fail rarely with a
BindExcep
Hi,
The test PortUnreachable closes a DatagramSocket and tries to rebind it
to the same port, this causes the test to fail rarely with a
BindException (I did 500 test runs and couldn't observe a failure). To
decrease the likelihood of this to happen, the fix increases the number
of bind retri
This test doesn't test NetworkChannel.
But it does check that the adapters behave consistently with the spec
of their java.net super class. I don't think there's anything
to remove.
best regards,
-- daniel
On 04/12/2019 10:33, Chris Hegarty wrote:
>
> I guess the test is okay but it's not re
On 03/12/2019 16:39, Daniel Fuchs wrote:
Thanks for the review Alan!
new webrev: http://cr.openjdk.java.net/~dfuchs/webrev_8235141/webrev.01/
Looks good to me.
On 03/12/2019 21:19, Alan Bateman wrote:> On 03/12/2019 16:39, Daniel
Fuchs wrote:
>>...
>
> I guess the test is okay but it's
11 matches
Mail list logo
