Re: RFR: 8235459: HttpRequest.BodyPublishers#ofFile(Path) assumes the default file system

2020-03-05 Thread Anthony Vanelverdinghe
Hi Julia Here's some suggestions w.r.t. RequestPublishers.java: For distinguishing the non-default filesystem case, an alternative to using the try-catch block is an if-else block with the same check as is done in Path::toFile:     if (path.getFileSystem() == FileSystems.getDefault()) When se

RFR: 8235459: HttpRequest.BodyPublishers#ofFile(Path) assumes the default file system

2020-03-05 Thread Julia Boes
Hi, Please see this fix that adds support for non-default file systems to the HttpClient. More specifically, the change is in RequestPublishers.FilePublisher where an UnsupportedOperationException is thrown if a java.io.File cannot be obtained. The exception is now caught and a function is us

Re: RFR 8237858: PlainSocketImpl.socketAccept() handles EINTR incorrectly

2020-03-05 Thread Vyom Tewari26
  Ping,   please review the below code.   Vyom - Original message -From: "Vyom Tewari26" Sent by: "net-dev" To: net-dev@openjdk.java.netCc:Subject: [EXTERNAL] RFR 8237858: PlainSocketImpl.socketAccept() handles EINTR incorrectlyDate: Tue, Feb 25, 2020 10:07 PM  Hi ,   Please find the below