Hi Julia,
I think we need to revisit the
public static FilePublisher create(Path path)
a bit.
We should try to call Path::toFile first - whether there is a security
manager or not. In the case where that succeeds, we can use
new FileInputStream(), otherwise, we use Files.newInputStream.
It's
Thanks for the review, Chris.
After running further httpclient tests, I had to adjusted the exception
handling of an existing test, RelayingPublishers.
I also added a check in FilePublisher::createInputStream to throw if the
path is of a directory.
Updated webrev: http://cr.openjdk.java.net
On 11/03/2020 16:54, Patrick Concannon wrote:
http://cr.openjdk.java.net/~pconcannon/8239355/webrevs/webrev.03/
Looks good to me Patrick!
best regards,
-- daniel
