Re: [15] RFR 8241760 : Typos: empty lines in javadoc, inconsistent indents, etc. (net and nio)

2020-03-30 Thread Ivan Gerasimov
Thank you guy for your reviews! Pushed. On 3/30/20 5:27 AM, Daniel Fuchs wrote: Looks good to me Ivan. Thanks for this cleanup! best regards, -- daniel On 30/03/2020 03:34, Ivan Gerasimov wrote: Thank you Alan and Pavel! My apologies for a wrong link in the initial request. Here's the n

Re: RFR[8241072]: 'Reimplement Legacy DatagramSocket API'

2020-03-30 Thread Patrick Concannon
Hi Alan, Thanks for your feedback. I've incorporated your comments into the revised webrev below. http://cr.openjdk.java.net/~pconcannon/8241072/webrevs/webrev.01/ With regards to the UnreferencedXXX tests, I can take a look at these separately. -Patrick On 23/03/2020 18:59, Alan Bateman

Re: RFR JDK-8239595/JDK-8239594 : ssl context version is not respected/jdk.tls.client.protocols is not respected

2020-03-30 Thread rahul . r . yadav
The current fix does not affect the scenarios discussed earlier(that is a broader discussion,may be a different bug/enhancement). The scenarios would be vaild even if the fix would not have been in place. -Rahul On 27/03/2020 17:50, Chris Hegarty wrote: Thank you for these clarifications. We wi

Re: [15] RFR 8241760 : Typos: empty lines in javadoc, inconsistent indents, etc. (net and nio)

2020-03-30 Thread Daniel Fuchs
Looks good to me Ivan. Thanks for this cleanup! best regards, -- daniel On 30/03/2020 03:34, Ivan Gerasimov wrote: Thank you Alan and Pavel! My apologies for a wrong link in the initial request. Here's the new webrev with the changes suggested by Pavel: http://cr.openjdk.java.net/~igerasi

Re: [15] RFR 8241760 : Typos: empty lines in javadoc, inconsistent indents, etc. (net and nio)

2020-03-30 Thread Pavel Rappo
Looks good. Thanks. > On 30 Mar 2020, at 03:34, Ivan Gerasimov wrote: > > Thank you Alan and Pavel! > > My apologies for a wrong link in the initial request. > > Here's the new webrev with the changes suggested by Pavel: > > http://cr.openjdk.java.net/~igerasim/8241760/01/webrev/ > > With ki

Re: Java 14 - Change in InetSocketAddress.toString() behaviour seems to be causing issues

2020-03-30 Thread Chris Hegarty
Hi Jaikiran, Thank you for posting this message to net-dev. TL;DR seems like the specific issue raised against Quarkus has been resolved ( by upgrading to a more recent version of ZooKeeper ). > On 28 Mar 2020, at 06:43, Jaikiran Pai wrote: > > There's an issue raised in Quarkus repo[1], whe

Re: Java 14 - Change in InetSocketAddress.toString() behaviour seems to be causing issues

2020-03-30 Thread Alan Bateman
On 28/03/2020 06:43, Jaikiran Pai wrote: There's an issue raised in Quarkus repo[1], where Apache Kafka (embedded) no longer starts on Java 14. From what I can see the root cause is this[2]. JDK-8225499[3] changed the implementation (and even the javadoc) of the InetSocketAddress.toString()