Re: RFR[8237890]: 'DatagramPacket::getSocketAddress doesn't specify what happens if address or port are not set'

2020-04-10 Thread mark sheppard
Hi Patrick, if I understand the change correctly, you wish to eliminate the IllegalArgumentException and return an InetSocketAddress based on the current set values for address and port. Because you have changed the default value of the port to 0, the getSocketAddress will now return a

Re: RFR[8237890]: 'DatagramPacket::getSocketAddress doesn't specify what happens if address or port are not set'

2020-04-10 Thread Alan Bateman
On 10/04/2020 11:16, Patrick Concannon wrote: Hi, Could someone please review my webrev and CSR for JDK-8237890 'DatagramPacket::getSocketAddress doesn't specify what happens if address or port are not set' ? DatagramPacket::getSocketAddress is misleading in that it can throw an

RFR[8237890]: 'DatagramPacket::getSocketAddress doesn't specify what happens if address or port are not set'

2020-04-10 Thread Patrick Concannon
Hi, Could someone please review my webrev and CSR for JDK-8237890 'DatagramPacket::getSocketAddress doesn't specify what happens if address or port are not set' ? DatagramPacket::getSocketAddress is misleading in that it can throw an IllegalArgumentException even though it doesn't take any