Re: RFR[8244582]: 'Remove terminally deprecated Solaris-specific SO_FLOW_SLA socket option'

Hi Patrick, Changes looks good to me. Thanks, Vyom On Wed, May 27, 2020 at 9:12 PM Patrick Concannon < patrick.concan...@oracle.com> wrote: > Hi, > > Could someone please review my webrev and CSR for JDK-8244582 'Remove > terminally deprecated Solaris-specific SO_FLOW_SLA socket option'? > > Th

Re: RFR: 8237470: HttpResponse.BodySubscriber::ofFile throws UOE with non-default file systems

Looks good to me Julia! best regards, -- daniel On 27/05/2020 10:00, Julia Boes wrote: Hi, We recently added support for non-default file systems to the HttpClient on the sending side. This fix expands the support to the receiving side. More specifically, the change is in ResponseBodyHandl

Re: RFR[8244582]: 'Remove terminally deprecated Solaris-specific SO_FLOW_SLA socket option'

Hi Patrick, Some copyright years need to be updated. Otherwise LGTM! best regards, -- daniel On 27/05/2020 16:41, Patrick Concannon wrote: Hi, Could someone please review my webrev and CSR for JDK-8244582 'Remove terminally deprecated Solaris-specific SO_FLOW_SLA socket option'? This patc

Re: RFR: 8237470: HttpResponse.BodySubscriber::ofFile throws UOE with non-default file systems

Julia, > On 27 May 2020, at 10:00, Julia Boes wrote: > > .. > CSR (draft): https://bugs.openjdk.java.net/browse/JDK-8245770 I added myself as reviewer. > Webrev: http://cr.openjdk.java.net/~jboes/webrevs/8237470/webrev.00/ Looks v. good to me Julia. Thanks, -Chris.

Re: RFR[8244582]: 'Remove terminally deprecated Solaris-specific SO_FLOW_SLA socket option'

Patrick, > On 27 May 2020, at 16:41, Patrick Concannon > wrote: > > ... > bug: https://bugs.openjdk.java.net/browse/JDK-8244582 > csr: https://bugs.openjdk.java.net/browse/JDK-8245984 > webrev: http://cr.openjdk.java.net/~pconcannon/8245828/webrevs/webrev.00/ LGTM. -Chris.

Re: RFR[8244582]: 'Remove terminally deprecated Solaris-specific SO_FLOW_SLA socket option'

On 27/05/2020 16:41, Patrick Concannon wrote: Hi, Could someone please review my webrev and CSR for JDK-8244582 'Remove terminally deprecated Solaris-specific SO_FLOW_SLA socket option'? This patch removes `ExtendedSocketOptions. SO_FLOW_SLA`, `SocketFlow` and `SocketFlow.Status` which were

RFR[8244582]: 'Remove terminally deprecated Solaris-specific SO_FLOW_SLA socket option'

Hi, Could someone please review my webrev and CSR for JDK-8244582 'Remove terminally deprecated Solaris-specific SO_FLOW_SLA socket option'? This patch removes `ExtendedSocketOptions. SO_FLOW_SLA`, `SocketFlow` and `SocketFlow.Status` which were terminally deprecated in JDK 14 in preparation

RFR: 8237470: HttpResponse.BodySubscriber::ofFile throws UOE with non-default file systems

Hi, We recently added support for non-default file systems to the HttpClient on the sending side. This fix expands the support to the receiving side. More specifically, the change is in ResponseBodyHandlers.PathBodyHandler and ResponseSubscribers.PathSubscriber. In both cases, an Unsupported