Re: RFR: 8254871: Remove unnecessary string copy in NetworkInterface.c

2020-10-26 Thread Eric Liu
On Fri, 23 Oct 2020 03:18:27 GMT, Eric Liu wrote: > A small improvement to avoid extra string copy. > > [Tests] > Jtreg hotspot::hotspot_all_no_apps, jdk::jdk_core and langtools::tier1. > No new failure found. @kimbarrett Could you help to take look at this trivial patch? - PR: h

Re: RFR(s): Improving performance of Windows socket connect on the loopback adapter

2020-10-26 Thread Mat Carter
Nikola has opened an issue to cover the loopback address range and we're preparing a patch: https://bugs.openjdk.java.net/browse/JDK-8255264 We've identified some unit tests to include in the patch, does gtest/runtime/test_os_windows.cpp seem the appropriate location for them? Patch (preview):

RFR: 8255405: sun/net/ftp/imp/FtpClient uses SimpleDateFormat in not thread-safe manner

2020-10-26 Thread Igor Ignatyev
Hi all, could you please review this small and trivial fix? `sun/net/ftp/imp/FtpClient::dateFormats` is an array of `SimpleDateFormat` which are shared among all instances of `FtpClient`. the fact that `SimpleDateFormat` isn't thread-safe renders`FtpClient` to be non-thread-safe as well. the p

Re: RFR: 8255078: sun/net/ftp/imp/FtpClient$MLSxParser uses wrong datetime format [v3]

2020-10-26 Thread Igor Ignatyev
On Sun, 25 Oct 2020 00:35:20 GMT, Marcono1234 wrote: >> Igor Ignatyev has updated the pull request incrementally with one additional >> commit since the last revision: >> >> use only filename in assert message > > src/java.base/share/classes/sun/net/ftp/impl/FtpClient.java line 1777: > >> 1