Re: RFR: JDK-8212035 : merge jdk.test.lib.util.SimpleHttpServer with jaxp.library.SimpleHttpServer [v4]

2020-12-11 Thread Mahendra Chhipa
> jaxp.library.SimpleHttpServer > https://bugs.openjdk.java.net/browse/JDK-8212035 Mahendra Chhipa has updated the pull request incrementally with two additional commits since the last revision: - Merge branch 'JDK-8212035' of https://github.com/mahendrachhipa/jdk into JDK-8212035 - Implemnte

Re: RFR: JDK-8212035 : merge jdk.test.lib.util.SimpleHttpServer with jaxp.library.SimpleHttpServer [v2]

2020-12-11 Thread Mahendra Chhipa
On Tue, 8 Dec 2020 18:01:20 GMT, Daniel Fuchs wrote: >> Mahendra Chhipa has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Implemented the review comments. > > test/lib/jdk/test/lib/net/SimpleHttpServer.java line 83: > >> 81: //let

Re: RFR: JDK-8212035 : merge jdk.test.lib.util.SimpleHttpServer with jaxp.library.SimpleHttpServer [v3]

2020-12-11 Thread Mahendra Chhipa
> jaxp.library.SimpleHttpServer > https://bugs.openjdk.java.net/browse/JDK-8212035 Mahendra Chhipa has updated the pull request incrementally with one additional commit since the last revision: Implemnted the review comments. - Changes: - all: https://git.openjdk.java.net/jdk/p

Re: RFR: JDK-8212035 : merge jdk.test.lib.util.SimpleHttpServer with jaxp.library.SimpleHttpServer [v2]

2020-12-11 Thread Daniel Fuchs
On Tue, 8 Dec 2020 16:51:02 GMT, Mahendra Chhipa wrote: >> jaxp.library.SimpleHttpServer >> https://bugs.openjdk.java.net/browse/JDK-8212035 > > Mahendra Chhipa has updated the pull request incrementally with one > additional commit since the last revision: > > Implemented the review comment

Integrated: 8255583: Investigate creating a test to trigger the condition in KeepAliveStreamCleaner

2020-12-11 Thread Conor Cleary
On Mon, 7 Dec 2020 09:52:47 GMT, Conor Cleary wrote: > The KeepAliveStreamCleaner in sun.net.ww.http package had been previously > seen to fail with an IllegalMonitorStateException. This failure was caused by > the use of `wait()` in a non synchronized block. This failure was mitigated > throu

Re: RFR: 8255477: Remove unused method URL.set(String protocol, String host, int port, String file, String ref) [v2]

2020-12-11 Thread Daniel Fuchs
On Fri, 11 Dec 2020 08:06:53 GMT, Alan Bateman wrote: >> Marked as reviewed by dfuchs (Reviewer). > > I think Daniel is going to sponsor this. Sorry - I lost track of this - thanks of reminding me. I will sponsor later today. - PR: https://git.openjdk.java.net/jdk/pull/779

Re: icmp and raw sockets on linux

2020-12-11 Thread Daniel Fuchs
I Jamie, Yes - you will need at least one Reviewer and then a sponsor. From the brief glance I had at your patch it looked reasonable. Let me have a deeper look. best regards, -- daniel On 09/12/2020 18:35, Jamie Le Tual wrote: I'm wondering what the process is for the pull request I submitted

Re: RFR: 8255477: Remove unused method URL.set(String protocol, String host, int port, String file, String ref) [v2]

2020-12-11 Thread Alan Bateman
On Fri, 27 Nov 2020 09:59:29 GMT, Daniel Fuchs wrote: >> Сергей Цыпанов has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains two additional >> commit