Re: RFR: 8224775: test/jdk/com/sun/jdi/JdwpListenTest.java failed to attach [v2]

2021-02-23 Thread Daniel Fuchs
On Mon, 22 Feb 2021 21:36:52 GMT, Alex Menkov wrote: >> The fix also partially fixes JdwpAttachTest failures (JDK-8253940). >> The failures are caused by network configuration changes during test >> execution ("global" IPv6 addresses disappears from interface). >> To minimize chances of intermit

Re: RFR: 8262027: Improve how HttpConnection detects a closed channel when taking/returning a connection to the pool [v5]

2021-02-23 Thread Chris Hegarty
On Mon, 22 Feb 2021 16:44:15 GMT, Daniel Fuchs wrote: >> Hi, >> >> Please find here a fix for: >> 8262027: Improve how HttpConnection detects a closed channel when >> taking/returning a connection to the pool >> >> While writing a new test to verify that it was possible to handle proxy >> *an

Re: RFR: 8262027: Improve how HttpConnection detects a closed channel when taking/returning a connection to the pool [v6]

2021-02-23 Thread Daniel Fuchs
> Hi, > > Please find here a fix for: > 8262027: Improve how HttpConnection detects a closed channel when > taking/returning a connection to the pool > > While writing a new test to verify that it was possible to handle proxy *and* > server authentication manually when both proxy and server req

Re: RFR: 8262027: Improve how HttpConnection detects a closed channel when taking/returning a connection to the pool [v5]

2021-02-23 Thread Daniel Fuchs
On Tue, 23 Feb 2021 14:06:41 GMT, Chris Hegarty wrote: >> Daniel Fuchs has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains six additional >> commits

Re: RFR: 8262027: Improve how HttpConnection detects a closed channel when taking/returning a connection to the pool [v2]

2021-02-23 Thread Michael McMahon
On Mon, 22 Feb 2021 16:44:40 GMT, Daniel Fuchs wrote: >> Right, I was mistaken. It actually is related to this change. You are >> testing what happens *if* the proxy closes the connection. Though that >> wouldn't be normal behavior for a proxy. If you are sending 407 to the >> client then you

Re: RFR: 8262027: Improve how HttpConnection detects a closed channel when taking/returning a connection to the pool [v6]

2021-02-23 Thread Michael McMahon
On Tue, 23 Feb 2021 17:20:13 GMT, Daniel Fuchs wrote: >> Hi, >> >> Please find here a fix for: >> 8262027: Improve how HttpConnection detects a closed channel when >> taking/returning a connection to the pool >> >> While writing a new test to verify that it was possible to handle proxy >> *an