Re: RFR: 8263899: HttpClient throws NPE in AuthenticationFilter when parsing www-authenticate head [v3]

2021-03-24 Thread Daniel Fuchs
On Mon, 22 Mar 2021 10:06:08 GMT, Michael McMahon wrote: >> Could I get the following simple fix reviewed please? >> >> The bug is jdk.internal.net.http.AuthenticationFilter throws an NPE wrapped >> in an IOException if it receives a HTTP response containing a >> WWW-Authenticate header with

Re: RFR: 8263899: HttpClient throws NPE in AuthenticationFilter when parsing www-authenticate head [v3]

2021-03-24 Thread Michael McMahon
On Mon, 22 Mar 2021 10:31:19 GMT, Daniel Fuchs wrote: >> Michael McMahon has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fix whitespace error > > test/jdk/java/net/httpclient/EmptyAuthenticate.java line 63: > >> 61: //run client

Re: RFR: 8263899: HttpClient throws NPE in AuthenticationFilter when parsing www-authenticate head [v4]

2021-03-24 Thread Daniel Fuchs
On Tue, 23 Mar 2021 13:45:06 GMT, Michael McMahon wrote: >> Could I get the following simple fix reviewed please? >> >> The bug is jdk.internal.net.http.AuthenticationFilter throws an NPE wrapped >> in an IOException if it receives a HTTP response containing a >> WWW-Authenticate header with

Re: RFR: 8263899: HttpClient throws NPE in AuthenticationFilter when parsing www-authenticate head [v3]

2021-03-24 Thread Daniel Fuchs
On Wed, 24 Mar 2021 11:06:47 GMT, Michael McMahon wrote: >> test/jdk/java/net/httpclient/EmptyAuthenticate.java line 63: >> >>> 61: //run client: >>> 62: try { >>> 63: HttpClient httpClient = HttpClient.newHttpClient(); >> >> Hmmm... Does this happen even when there'

Re: RFR: 8263899: HttpClient throws NPE in AuthenticationFilter when parsing www-authenticate head [v4]

2021-03-24 Thread Chris Hegarty
On Tue, 23 Mar 2021 13:45:06 GMT, Michael McMahon wrote: >> Could I get the following simple fix reviewed please? >> >> The bug is jdk.internal.net.http.AuthenticationFilter throws an NPE wrapped >> in an IOException if it receives a HTTP response containing a >> WWW-Authenticate header with

Integrated: 8263899: HttpClient throws NPE in AuthenticationFilter when parsing www-authenticate head

2021-03-24 Thread Michael McMahon
On Mon, 22 Mar 2021 09:26:08 GMT, Michael McMahon wrote: > Could I get the following simple fix reviewed please? > > The bug is jdk.internal.net.http.AuthenticationFilter throws an NPE wrapped > in an IOException if it receives a HTTP response containing a > WWW-Authenticate header with no va

Re: RFR: JDK-8262992: Improve `@see` output [v2]

2021-03-24 Thread Jonathan Gibbons
On Thu, 11 Mar 2021 15:17:50 GMT, Jonathan Gibbons wrote: >> Hannes Wallnöfer has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update `@see` tag in class java.security.cert.PKIXRevocationChecker > > Nice! I like the basic change to `Tagl