Re: RFR: 8266250: WebSocketTest and WebSocketProxyTest call assertEquals(List, List)

2021-04-28 Thread Pavel Rappo
On Wed, 28 Apr 2021 21:22:23 GMT, Daniel Fuchs wrote: > It also avoids relying on an unspecified behavior of `Assert.assertEquals`. Which behavior is that? If I recall correctly, the test was written for TestNG 6.9.5, which provides a [method to compare

RFR: 8266250: WebSocketTest and WebSocketProxyTest call assertEquals(List, List)

2021-04-28 Thread Daniel Fuchs
Please find here an almost trivial test fix that should improve diagnostic in case of failures. It also avoids relying on an unspecified behavior of `Assert.assertEquals`. - Commit messages: - 8266250: WebSocketTest and WebSocketProxyTest call assertEquals(List, List) Changes:

Re: RFR: 8266155: Convert java.base to use Stream.toList() [v2]

2021-04-28 Thread Chris Hegarty
On Wed, 28 Apr 2021 16:57:25 GMT, Ian Graves wrote: >> 8266155: Convert java.base to use Stream.toList() > > Ian Graves has updated the pull request incrementally with one additional > commit since the last revision: > > Removing redundant imports Marked as reviewed by chegar (Reviewer).

Re: RFR: 8266155: Convert java.base to use Stream.toList() [v2]

2021-04-28 Thread Iris Clark
On Wed, 28 Apr 2021 16:57:25 GMT, Ian Graves wrote: >> 8266155: Convert java.base to use Stream.toList() > > Ian Graves has updated the pull request incrementally with one additional > commit since the last revision: > > Removing redundant imports Marked as reviewed by iris (Reviewer).

Re: RFR: 8266155: Convert java.base to use Stream.toList() [v2]

2021-04-28 Thread Ian Graves
> 8266155: Convert java.base to use Stream.toList() Ian Graves has updated the pull request incrementally with one additional commit since the last revision: Removing redundant imports - Changes: - all: https://git.openjdk.java.net/jdk/pull/3734/files - new:

Re: RFR: 8266155: Convert java.base to use Stream.toList()

2021-04-28 Thread Alan Bateman
On Wed, 28 Apr 2021 15:41:31 GMT, Chris Hegarty wrote: >> 8266155: Convert java.base to use Stream.toList() > > src/java.base/share/classes/java/lang/invoke/MethodHandles.java line 6788: > >> 6786: } >> 6787: >> 6788: /** > > I think the import of Collectors can be dropped in this

Re: RFR: 8266155: Convert java.base to use Stream.toList()

2021-04-28 Thread Chris Hegarty
On Tue, 27 Apr 2021 21:34:02 GMT, Ian Graves wrote: > 8266155: Convert java.base to use Stream.toList() Marked as reviewed by chegar (Reviewer). src/java.base/share/classes/java/lang/invoke/MethodHandles.java line 6788: > 6786: } > 6787: > 6788: /** I think the import of Collectors

Re: RFR: 8265123: Add static factory methods to com.sun.net.httpserver.Filter [v6]

2021-04-28 Thread Daniel Fuchs
On Wed, 28 Apr 2021 14:32:30 GMT, Julia Boes wrote: >> Add two static factory methods to com.sun.net.httpserver.Filter that >> facilitate the creation of pre- and post-processing Filters: >> >> `public static Filter beforeResponse(String description, >> Consumer filterImpl) {}` >> `public

Re: RFR: 8265123: Add static factory methods to com.sun.net.httpserver.Filter [v5]

2021-04-28 Thread Michael McMahon
On Wed, 28 Apr 2021 13:20:23 GMT, Julia Boes wrote: >> Add two static factory methods to com.sun.net.httpserver.Filter that >> facilitate the creation of pre- and post-processing Filters: >> >> `public static Filter beforeResponse(String description, >> Consumer filterImpl) {}` >> `public

Re: RFR: 8265123: Add static factory methods to com.sun.net.httpserver.Filter [v5]

2021-04-28 Thread Julia Boes
> Add two static factory methods to com.sun.net.httpserver.Filter that > facilitate the creation of pre- and post-processing Filters: > > `public static Filter beforeResponse(String description, > Consumer filterImpl) {}` > `public static Filter afterResponse(String description, > Consumer

Re: RFR: 8265123: Add static factory methods to com.sun.net.httpserver.Filter [v4]

2021-04-28 Thread Michael McMahon
On Wed, 28 Apr 2021 11:29:18 GMT, Julia Boes wrote: >> Add two static factory methods to com.sun.net.httpserver.Filter that >> facilitate the creation of pre- and post-processing Filters: >> >> `public static Filter beforeResponse(String description, >> Consumer filterImpl) {}` >> `public

Re: RFR: 8265123: Add static factory methods to com.sun.net.httpserver.Filter [v4]

2021-04-28 Thread Daniel Fuchs
On Wed, 28 Apr 2021 11:29:18 GMT, Julia Boes wrote: >> Add two static factory methods to com.sun.net.httpserver.Filter that >> facilitate the creation of pre- and post-processing Filters: >> >> `public static Filter beforeResponse(String description, >> Consumer filterImpl) {}` >> `public

Re: RFR: 8265123: Add static factory methods to com.sun.net.httpserver.Filter [v4]

2021-04-28 Thread Julia Boes
> Add two static factory methods to com.sun.net.httpserver.Filter that > facilitate the creation of pre- and post-processing Filters: > > `public static Filter beforeResponse(String description, > Consumer filterImpl) {}` > `public static Filter afterResponse(String description, > Consumer

Re: RFR: 8265123: Add static factory methods to com.sun.net.httpserver.Filter [v4]

2021-04-28 Thread Chris Hegarty
On Wed, 28 Apr 2021 11:26:18 GMT, Julia Boes wrote: >> Add two static factory methods to com.sun.net.httpserver.Filter that >> facilitate the creation of pre- and post-processing Filters: >> >> `public static Filter beforeResponse(String description, >> Consumer filterImpl) {}` >> `public