On Tue, 1 Jun 2021 12:09:26 GMT, Daniel Fuchs wrote:
> Please find below a trivial change to improve diagnostic in case of failure
> in the HandshakeFailureTest.
> The AssertionError observed will have more information next time it fires,
> and the stack trace will appear as the cause of the ru
On Tue, 1 Jun 2021 17:16:59 GMT, Patrick Concannon
wrote:
>> src/java.base/share/classes/java/nio/file/attribute/FileTime.java line 256:
>>
>>> 254: nanos = (int) Math.floorMod(value,
>>> NANOS_PER_SECOND);
>>> 255: }
>>> 256: default -> thro
On Tue, 1 Jun 2021 17:20:38 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my code for updating the code in the `java.net`
>> and `java.nio` packages to make use of the switch expressions?
>>
>> Kind regards,
>> Patrick
>
> Patrick Concannon has updated the pull reques
On Tue, 1 Jun 2021 16:56:39 GMT, Alan Bateman wrote:
>> Patrick Concannon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8268056: Reverted changes to URLDecoder; reformatted change to FileTime
>
> src/java.base/share/classes/java/nio/fi
On Tue, 1 Jun 2021 16:56:36 GMT, Daniel Fuchs wrote:
>> Patrick Concannon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8268056: Reverted changes to URLDecoder; reformatted change to FileTime
>
> src/java.base/share/classes/java/net/UR
> Hi,
>
> Could someone please review my code for updating the code in the `java.net`
> and `java.nio` packages to make use of the switch expressions?
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request incrementally with one
additional commit since the last revision:
On Mon, 31 May 2021 16:21:29 GMT, Daniel Fuchs wrote:
> The Utils.remaining(List list) method assumes that it can and
> should synchronize on the given list to prevent concurrent modification. In
> 99% of the cases this assumption is wrong. There's only one such list (the
> SSLFlowDelegate wri
On Tue, 1 Jun 2021 16:44:38 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my code for updating the code in the `java.net`
> and `java.nio` packages to make use of the switch expressions?
>
> Kind regards,
> Patrick
src/java.base/share/classes/java/nio/file/attribute/Fil
On Tue, 1 Jun 2021 16:44:38 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my code for updating the code in the `java.net`
> and `java.nio` packages to make use of the switch expressions?
>
> Kind regards,
> Patrick
src/java.base/share/classes/java/net/URLDecoder.java li
Hi,
Could someone please review my code for updating the code in the `java.net` and
`java.nio` packages to make use of the switch expressions?
Kind regards,
Patrick
-
Commit messages:
- 8268056: Update java.net and java.nio to use switch expressions
Changes: https://git.openjdk.j
On Tue, 1 Jun 2021 15:21:33 GMT, Weijun Wang wrote:
>> Please review this implementation of [JEP
>> 411](https://openjdk.java.net/jeps/411).
>>
>> The code change is divided into 3 commits. Please review them one by one.
>>
>> 1.
>> https://github.com/openjdk/jdk/commit/576161d15423f58281e384
On Tue, 1 Jun 2021 15:21:33 GMT, Weijun Wang wrote:
>> Please review this implementation of [JEP
>> 411](https://openjdk.java.net/jeps/411).
>>
>> The code change is divided into 3 commits. Please review them one by one.
>>
>> 1.
>> https://github.com/openjdk/jdk/commit/576161d15423f58281e384
> Please review this implementation of [JEP
> 411](https://openjdk.java.net/jeps/411).
>
> The code change is divided into 3 commits. Please review them one by one.
>
> 1.
> https://github.com/openjdk/jdk/commit/576161d15423f58281e384174d28c9f9be7941a1
> The essential change for this JEP, incl
> Please review this implementation of [JEP
> 411](https://openjdk.java.net/jeps/411).
>
> The code change is divided into 3 commits. Please review them one by one.
>
> 1.
> https://github.com/openjdk/jdk/commit/576161d15423f58281e384174d28c9f9be7941a1
> The essential change for this JEP, incl
On Tue, 1 Jun 2021 12:09:26 GMT, Daniel Fuchs wrote:
> Please find below a trivial change to improve diagnostic in case of failure
> in the HandshakeFailureTest.
> The AssertionError observed will have more information next time it fires,
> and the stack trace will appear as the cause of the ru
On Mon, 31 May 2021 15:02:57 GMT, Weijun Wang wrote:
>> Please review this implementation of [JEP
>> 411](https://openjdk.java.net/jeps/411).
>>
>> The code change is divided into 3 commits. Please review them one by one.
>>
>> 1.
>> https://github.com/openjdk/jdk/commit/576161d15423f58281e38
Please find below a trivial change to improve diagnostic in case of failure in
the HandshakeFailureTest.
The AssertionError observed will have more information next time it fires, and
the stack trace will appear as the cause of the runtime exception thrown by the
test.
-
Commit mes
17 matches
Mail list logo
