Re: [jdk17] RFR: 8268555: Update HttpClient tests that use ITestContext to jtreg 6+1

2021-06-11 Thread Chris Hegarty
On Thu, 10 Jun 2021 17:39:58 GMT, Daniel Fuchs wrote: > Another change brought by jtreg 6+1 in the behavior of @BeforeMethod. > Now throwing an exception in @BeforeMethod causes all annotated methods to be > skipped, not just those annotated with @Test. > > HttpClient tests that use @BeforeMeth

[jdk17] Integrated: 8268555: Update HttpClient tests that use ITestContext to jtreg 6+1

2021-06-11 Thread Daniel Fuchs
On Thu, 10 Jun 2021 17:39:58 GMT, Daniel Fuchs wrote: > Another change brought by jtreg 6+1 in the behavior of @BeforeMethod. > Now throwing an exception in @BeforeMethod causes all annotated methods to be > skipped, not just those annotated with @Test. > > HttpClient tests that use @BeforeMeth

Unix Domain Socket with Websocket

2021-06-11 Thread Christos Vasilakis
Hello all, we've a native application (in C) that exposes a json-rpc interface over a Unix Domain Socket using websocket. I know that the upcoming Java 17 release will include support for unix domain sockets and I'm wondering if the included websocket client (since Java 11) will also support thi

Re: Unix Domain Socket with Websocket

2021-06-11 Thread Daniel Fuchs
Hi Christos, The HttpClient doesn't support Unix Domain Socket - only regular TCP / TLS. You could of course open a connection with your client using a plain Unix Domain SocketChannel [1] using the UNIX ProtocolFamilly [2]. best regard, -- daniel [1] https://docs.oracle.com/en/java/javase/16

Re: Unix Domain Socket with Websocket

2021-06-11 Thread Michael McMahon
Yes, it does seem that for local RPC a regular (unix domain) socket should suffice rather than a websocket. Also, just to point out that Unix domain socket (channels) have been in the JDK since Java 16. - Michael. On 11/06/2021 10:22, Daniel Fuchs wrote: Hi Christos, The HttpClient doesn't

RFR: 8263364: sun/net/www/http/KeepAliveStream/KeepAliveStreamCloseWithWrongContentLength.java wedged in getInputStream

2021-06-11 Thread Ivan Šipka
@dfuch could you please review, thank you. - Commit messages: - 8263364: fixed headers - JDK-8263364: initial commit Changes: https://git.openjdk.java.net/jdk/pull/4472/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4472&range=00 Issue: https://bugs.openjdk.java.ne

Re: RFR: 8263364: sun/net/www/http/KeepAliveStream/KeepAliveStreamCloseWithWrongContentLength.java wedged in getInputStream

2021-06-11 Thread Daniel Fuchs
On Fri, 11 Jun 2021 10:46:32 GMT, Ivan Šipka wrote: > @dfuch could you please review, thank you. Globally looks good - still need some cleanup to make sure everything gets closed in the end. test/jdk/sun/net/www/http/KeepAliveStream/KeepAliveStreamCloseWithWrongContentLength.java line 56: >

Re: RFR: 8263364: sun/net/www/http/KeepAliveStream/KeepAliveStreamCloseWithWrongContentLength.java wedged in getInputStream

2021-06-11 Thread Daniel Fuchs
On Fri, 11 Jun 2021 10:46:32 GMT, Ivan Šipka wrote: > @dfuch could you please review, thank you. test/jdk/sun/net/www/http/KeepAliveStream/KeepAliveStreamCloseWithWrongContentLength.java line 139: > 137: is.close(); > 138: } catch (IOException e) { > 139: throw

Re: RFR: JDK-8268464 : Remove dependancy of TestHttpsServer, HttpTransaction, HttpCallback from open/test/jdk/sun/net/www/protocol/https/ tests [v2]

2021-06-11 Thread Mahendra Chhipa
> …HttpCallback from open/test/jdk/sun/net/www/protocol/https/ tests Mahendra Chhipa has updated the pull request incrementally with one additional commit since the last revision: Implemented review comments. - Changes: - all: https://git.openjdk.java.net/jdk/pull/4432/files

Re: RFR: JDK-8268464 : Remove dependancy of TestHttpsServer, HttpTransaction, HttpCallback from open/test/jdk/sun/net/www/protocol/https/ tests [v3]

2021-06-11 Thread Mahendra Chhipa
> …HttpCallback from open/test/jdk/sun/net/www/protocol/https/ tests Mahendra Chhipa has updated the pull request incrementally with one additional commit since the last revision: Remove extra space. - Changes: - all: https://git.openjdk.java.net/jdk/pull/4432/files - new: ht

Re: RFR: JDK-8268464 : Remove dependancy of TestHttpsServer, HttpTransaction, HttpCallback from open/test/jdk/sun/net/www/protocol/https/ tests [v3]

2021-06-11 Thread Daniel Fuchs
On Fri, 11 Jun 2021 13:38:14 GMT, Mahendra Chhipa wrote: >> …HttpCallback from open/test/jdk/sun/net/www/protocol/https/ tests > > Mahendra Chhipa has updated the pull request incrementally with one > additional commit since the last revision: > > Remove extra space. test/jdk/sun/net/www/pr

Re: Unix Domain Socket with Websocket

2021-06-11 Thread Christos Vasilakis
Thank you all for your replies. Kind regards -Christos On Fri, Jun 11, 2021 at 12:50 PM Michael McMahon < michael.x.mcma...@oracle.com> wrote: > Yes, it does seem that for local RPC a regular (unix domain) socket should > suffice > rather than a websocket. > > Also, just to point out that Unix d

Re: RFR: 8263364: sun/net/www/http/KeepAliveStream/KeepAliveStreamCloseWithWrongContentLength.java wedged in getInputStream [v2]

2021-06-11 Thread Ivan Šipka
> @dfuch could you please review, thank you. Ivan Šipka has updated the pull request incrementally with one additional commit since the last revision: 8263364: refactor - Changes: - all: https://git.openjdk.java.net/jdk/pull/4472/files - new: https://git.openjdk.java.net/jdk

Re: RFR: 8263364: sun/net/www/http/KeepAliveStream/KeepAliveStreamCloseWithWrongContentLength.java wedged in getInputStream [v2]

2021-06-11 Thread Ivan Šipka
On Fri, 11 Jun 2021 10:58:42 GMT, Daniel Fuchs wrote: >> Ivan Šipka has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8263364: refactor > > test/jdk/sun/net/www/http/KeepAliveStream/KeepAliveStreamCloseWithWrongContentLength.java > line 5

Re: RFR: 8263364: sun/net/www/http/KeepAliveStream/KeepAliveStreamCloseWithWrongContentLength.java wedged in getInputStream [v2]

2021-06-11 Thread Daniel Fuchs
On Fri, 11 Jun 2021 14:42:14 GMT, Ivan Šipka wrote: >> @dfuch could you please review, thank you. > > Ivan Šipka has updated the pull request incrementally with one additional > commit since the last revision: > > 8263364: refactor test/jdk/sun/net/www/http/KeepAliveStream/KeepAliveStreamCl

Re: RFR: 8263364: sun/net/www/http/KeepAliveStream/KeepAliveStreamCloseWithWrongContentLength.java wedged in getInputStream [v2]

2021-06-11 Thread Ivan Šipka
On Fri, 11 Jun 2021 14:48:56 GMT, Daniel Fuchs wrote: >> Ivan Šipka has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8263364: refactor > > test/jdk/sun/net/www/http/KeepAliveStream/KeepAliveStreamCloseWithWrongContentLength.java > line 1

Re: RFR: 8263364: sun/net/www/http/KeepAliveStream/KeepAliveStreamCloseWithWrongContentLength.java wedged in getInputStream [v3]

2021-06-11 Thread Ivan Šipka
> @dfuch could you please review, thank you. Ivan Šipka has updated the pull request incrementally with one additional commit since the last revision: 8263364: refactor - Changes: - all: https://git.openjdk.java.net/jdk/pull/4472/files - new: https://git.openjdk.java.net/jdk

Re: RFR: 8263364: sun/net/www/http/KeepAliveStream/KeepAliveStreamCloseWithWrongContentLength.java wedged in getInputStream [v2]

2021-06-11 Thread Ivan Šipka
On Fri, 11 Jun 2021 15:19:49 GMT, Ivan Šipka wrote: >> test/jdk/sun/net/www/http/KeepAliveStream/KeepAliveStreamCloseWithWrongContentLength.java >> line 120: >> >>> 118: public static void main (String[] args) throws Exception { >>> 119: >>> 120: final Integer port = 61234; >> >>

Re: RFR: 8263364: sun/net/www/http/KeepAliveStream/KeepAliveStreamCloseWithWrongContentLength.java wedged in getInputStream [v3]

2021-06-11 Thread Daniel Fuchs
On Fri, 11 Jun 2021 15:41:18 GMT, Ivan Šipka wrote: >> @dfuch could you please review, thank you. > > Ivan Šipka has updated the pull request incrementally with one additional > commit since the last revision: > > 8263364: refactor Looks good - small change still needed in `XServer::close`