RFR: 8268294: Reusing HttpClient in a WebSocket.Listener hangs.

2021-06-16 Thread Michael McMahon
Hi, This fixes a problem where the listener methods of a WebSocket client were being invoked by the Selector manager thread, which is problematic, because if the implementation of any of these methods tries to do any blocking work, this impacts other http activity, and if the blocking work is a

Re: RFR: 8268294: Reusing HttpClient in a WebSocket.Listener hangs.

2021-06-16 Thread Daniel Fuchs
On Wed, 16 Jun 2021 07:56:11 GMT, Michael McMahon wrote: > Hi, > > This fixes a problem where the listener methods of a WebSocket client were > being invoked by the Selector manager thread, which is problematic, because > if the implementation of any of these methods tries to do any blocking w

Re: RFR: 8268294: Reusing HttpClient in a WebSocket.Listener hangs.

2021-06-16 Thread Michael McMahon
On Wed, 16 Jun 2021 09:07:49 GMT, Daniel Fuchs wrote: >> Hi, >> >> This fixes a problem where the listener methods of a WebSocket client were >> being invoked by the Selector manager thread, which is problematic, because >> if the implementation of any of these methods tries to do any blocking

Re: RFR: 8268294: Reusing HttpClient in a WebSocket.Listener hangs.

2021-06-16 Thread Daniel Fuchs
On Wed, 16 Jun 2021 09:37:22 GMT, Michael McMahon wrote: >> test/jdk/java/net/httpclient/websocket/java.net.http/jdk/internal/net/http/websocket/WebSocketAndHttpClient.java >> line 38: >> >>> 36: HttpTest httpTest = new HttpTest(httpClient, args[1]); >>> 37: >>> 38: AtomicRefer

[jdk17] RFR: 8268776: Test `ADatagramSocket.java` missing /othervm from @run tag

2021-06-16 Thread Patrick Concannon
Hi, Could someone please review my change to the test `test/jdk/java/net/DatagramSocket/SetDatagramSocketImplFactory/ADatagramSocket.java`? The test is missing `/othervm` from its @run jtreg test tag, which risks polluting other tests that run in that VM. Currently, any test that runs without

Re: [jdk17] RFR: 8268776: Test `ADatagramSocket.java` missing /othervm from @run tag

2021-06-16 Thread Daniel Fuchs
On Wed, 16 Jun 2021 10:42:56 GMT, Patrick Concannon wrote: > Hi, > > Could someone please review my change to the test > `test/jdk/java/net/DatagramSocket/SetDatagramSocketImplFactory/ADatagramSocket.java`? > The test is missing `/othervm` from its @run jtreg test tag, which risks > pollutin

Re: RFR: 8268294: Reusing HttpClient in a WebSocket.Listener hangs. [v2]

2021-06-16 Thread Michael McMahon
> Hi, > > This fixes a problem where the listener methods of a WebSocket client were > being invoked by the Selector manager thread, which is problematic, because > if the implementation of any of these methods tries to do any blocking work, > this impacts other http activity, and if the blocki

Re: RFR: 8268294: Reusing HttpClient in a WebSocket.Listener hangs. [v3]

2021-06-16 Thread Michael McMahon
> Hi, > > This fixes a problem where the listener methods of a WebSocket client were > being invoked by the Selector manager thread, which is problematic, because > if the implementation of any of these methods tries to do any blocking work, > this impacts other http activity, and if the blocki

Re: RFR: 8268294: Reusing HttpClient in a WebSocket.Listener hangs. [v3]

2021-06-16 Thread Daniel Fuchs
On Wed, 16 Jun 2021 11:24:43 GMT, Michael McMahon wrote: >> Hi, >> >> This fixes a problem where the listener methods of a WebSocket client were >> being invoked by the Selector manager thread, which is problematic, because >> if the implementation of any of these methods tries to do any block

Re: RFR: 8268294: Reusing HttpClient in a WebSocket.Listener hangs. [v4]

2021-06-16 Thread Michael McMahon
> Hi, > > This fixes a problem where the listener methods of a WebSocket client were > being invoked by the Selector manager thread, which is problematic, because > if the implementation of any of these methods tries to do any blocking work, > this impacts other http activity, and if the blocki

[jdk17] RFR: 8268714: [macos-aarch64] 7 java/net/httpclient/websocket tests failed

2021-06-16 Thread Daniel Fuchs
Hi, Please find below a test-only change to fix some intermittent failures observed with the httpclient/websocket tests: these tests intermittently and randomly fail with ENOMEM ("No buffer space available"). Some machines in our CI seem to allow a higher level of concurrency while being (may

Re: [jdk17] RFR: 8268714: [macos-aarch64] 7 java/net/httpclient/websocket tests failed

2021-06-16 Thread Chris Hegarty
On Wed, 16 Jun 2021 13:53:38 GMT, Daniel Fuchs wrote: > Hi, > > Please find below a test-only change to fix some intermittent failures > observed with the httpclient/websocket tests: > these tests intermittently and randomly fail with ENOMEM ("No buffer space > available"). > > Some machines

Re: [jdk17] RFR: 8268714: [macos-aarch64] 7 java/net/httpclient/websocket tests failed

2021-06-16 Thread Michael McMahon
On Wed, 16 Jun 2021 13:53:38 GMT, Daniel Fuchs wrote: > Hi, > > Please find below a test-only change to fix some intermittent failures > observed with the httpclient/websocket tests: > these tests intermittently and randomly fail with ENOMEM ("No buffer space > available"). > > Some machines

Re: RFR: 8268294: Reusing HttpClient in a WebSocket.Listener hangs. [v4]

2021-06-16 Thread Daniel Fuchs
On Wed, 16 Jun 2021 12:07:25 GMT, Michael McMahon wrote: >> Hi, >> >> This fixes a problem where the listener methods of a WebSocket client were >> being invoked by the Selector manager thread, which is problematic, because >> if the implementation of any of these methods tries to do any block

[jdk17] Integrated: 8268714: [macos-aarch64] 7 java/net/httpclient/websocket tests failed

2021-06-16 Thread Daniel Fuchs
On Wed, 16 Jun 2021 13:53:38 GMT, Daniel Fuchs wrote: > Hi, > > Please find below a test-only change to fix some intermittent failures > observed with the httpclient/websocket tests: > these tests intermittently and randomly fail with ENOMEM ("No buffer space > available"). > > Some machines

Re: [jdk17] RFR: JDK-8265369 [macos-aarch64] java/net/MulticastSocket/Promiscuous.java failed with "SocketException: Cannot allocate memory" [v2]

2021-06-16 Thread Mark Sheppard
> JDK-8265369 [macos-aarch64] java/net/MulticastSocket/Promiscuous.java failed > with "SocketException: Cannot allocate memory" > > The test java/net/MulticastSocket/Promiscuous.java has been observed to fail > on a regular basis on macosx-aarch. > This is typically under heavy test load on a te

RFR: Merge jdk17

2021-06-16 Thread Jesper Wilhelmsson
Forwardport JDK 17 -> JDK 18 - Commit messages: - Merge - 8260194: Update the documentation for -Xcheck:jni - 8268863: ProblemList serviceability/sa/TestJmapCoreMetaspace.java on linux-x64 with ZGC - 8268909: ProblemList jdk/jfr/api/consumer/streaming/TestLatestEvent.java on win

Re: RFR: Merge jdk17 [v2]

2021-06-16 Thread Jesper Wilhelmsson
> Forwardport JDK 17 -> JDK 18 Jesper Wilhelmsson has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 35 additional commits since the last revision: - Me

Integrated: Merge jdk17

2021-06-16 Thread Jesper Wilhelmsson
On Thu, 17 Jun 2021 00:49:27 GMT, Jesper Wilhelmsson wrote: > Forwardport JDK 17 -> JDK 18 This pull request has now been integrated. Changeset: 3637e50b Author:Jesper Wilhelmsson URL: https://git.openjdk.java.net/jdk/commit/3637e50b30e92538510c1a8e8893cedc3bd4ccd5 Stats: 659 l