> `com.sun.net.httpserver.Headers` normalizes its keys to adhere to the
> following format: First character uppercase, all other characters lowercase,
> for example `"foo" -> "Foo"`. This behaviour is not consistent across the
> mutator methods of the class, in particular `putAll()` and `replace
On Wed, 9 Jun 2021 14:42:23 GMT, Mahendra Chhipa
wrote:
> …HttpCallback from open/test/jdk/sun/net/www/protocol/https/ tests
This pull request has now been integrated.
Changeset: 7621fa37
Author:Mahendra Chhipa
Committer: Michael McMahon
URL:
https://git.openjdk.java.net/jdk/commi
On Wed, 23 Jun 2021 15:01:45 GMT, Daniel Fuchs wrote:
>> This is probably a case where the spec needs say that an error (maybe an
>> unspecified error) is thrown if the custom factory's
>> createDatagramSocketImpl returns null. We can create a separate issue for
>> that as it's probably existe
On Wed, 23 Jun 2021 14:32:22 GMT, Alan Bateman wrote:
>> Yes - the constructor would throw NPE - but there's no need to call this
>> constructor if `impl` is null here - it's better to fail early.
>
> This is probably a case where the spec needs say that an error (maybe an
> unspecified error)
On Wed, 23 Jun 2021 12:10:54 GMT, Mahendra Chhipa
wrote:
>> …HttpCallback from open/test/jdk/sun/net/www/protocol/https/ tests
>
> Mahendra Chhipa has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Implemented reviw comments.
Marked as revie
On Wed, 23 Jun 2021 14:19:59 GMT, Daniel Fuchs wrote:
>> src/java.base/share/classes/java/net/DatagramSocket.java line 1405:
>>
>>> 1403: // create legacy DatagramSocket delegate
>>> 1404: DatagramSocketImpl impl =
>>> factory.createDatagramSocketImpl();
>>> 1405
On Wed, 23 Jun 2021 12:10:54 GMT, Mahendra Chhipa
wrote:
>> …HttpCallback from open/test/jdk/sun/net/www/protocol/https/ tests
>
> Mahendra Chhipa has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Implemented reviw comments.
Marked as revie
On Wed, 23 Jun 2021 13:05:24 GMT, Alan Bateman wrote:
>> Hi,
>>
>> Could someone please review my changes for the removal of the legacy
>> `PlainSocketImpl` and `PlainDatagramSocketImpl` implementations?
>>
>> In JDK 13, JEP 353 provided a drop in replacement for the legacy
>> `PlainSocketImp
On Wed, 23 Jun 2021 12:06:41 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my changes for the removal of the legacy
> `PlainSocketImpl` and `PlainDatagramSocketImpl` implementations?
>
> In JDK 13, JEP 353 provided a drop in replacement for the legacy
> `PlainSocketImpl
On Wed, 23 Jun 2021 12:06:41 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my changes for the removal of the legacy
> `PlainSocketImpl` and `PlainDatagramSocketImpl` implementations?
>
> In JDK 13, JEP 353 provided a drop in replacement for the legacy
> `PlainSocketImpl
Hi,
Could someone please review my changes for the removal of the legacy
`PlainSocketImpl` and `PlainDatagramSocketImpl` implementations?
In JDK 13, JEP 353 provided a drop in replacement for the legacy
`PlainSocketImpl` implementation. Since JDK 13, the `PlainSocketImpl`
implementation was no
> …HttpCallback from open/test/jdk/sun/net/www/protocol/https/ tests
Mahendra Chhipa has updated the pull request incrementally with one additional
commit since the last revision:
Implemented reviw comments.
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/4432/files
-
On Tue, 22 Jun 2021 11:59:11 GMT, Daniel Fuchs wrote:
>> There is an optimization opportunity for the widespread use-case when a
>> resource is read from classpath using
>> `getClass().getClassLoader().getResource()` or
>> `getClass().getClassLoader().getResourceAsStream()`.
>>
>> Pay attenti
13 matches
Mail list logo
