Re: RFR: 8269481: SctpMultiChannel never releases own file descriptor [v2]

2021-06-29 Thread Brian Burkhalter
On Tue, 29 Jun 2021 06:52:47 GMT, Alan Bateman wrote: >> Brian Burkhalter has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8269481: Set state to KILLED *before* closing socket > > src/jdk.sctp/unix/classes/sun/nio/ch/sctp/SctpChannelImpl.

Re: RFR: 8269481: SctpMultiChannel never releases own file descriptor [v2]

2021-06-29 Thread Brian Burkhalter
> Please review this change to the Unix implementations of > `sun.nio.ch.sctp.Sctp*ChannelImpl#kill()` to close the socket if `state == > ChannelState.UNINITIALIZED`. Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision: 8269481: Set

Re: RFR: 8269481: SctpMultiChannel never releases own file descriptor [v2]

2021-06-29 Thread Chris Hegarty
On Tue, 29 Jun 2021 16:10:44 GMT, Brian Burkhalter wrote: >> Please review this change to the Unix implementations of >> `sun.nio.ch.sctp.Sctp*ChannelImpl#kill()` to close the socket if `state == >> ChannelState.UNINITIALIZED`. > > Brian Burkhalter has updated the pull request incrementally wit

Re: RFR: 8269481: SctpMultiChannel never releases own file descriptor [v2]

2021-06-29 Thread Brian Burkhalter
On Tue, 29 Jun 2021 16:55:33 GMT, Chris Hegarty wrote: >> Brian Burkhalter has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8269481: Set state to KILLED *before* closing socket > > src/jdk.sctp/unix/classes/sun/nio/ch/sctp/SctpMultiChanne

Re: RFR: 8269481: SctpMultiChannel never releases own file descriptor [v2]

2021-06-29 Thread Brian Burkhalter
On Tue, 29 Jun 2021 16:58:53 GMT, Chris Hegarty wrote: >> Brian Burkhalter has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8269481: Set state to KILLED *before* closing socket > > test/jdk/com/sun/nio/sctp/SctpMultiChannel/CloseDescripto

Re: RFR: 8269481: SctpMultiChannel never releases own file descriptor [v3]

2021-06-29 Thread Brian Burkhalter
> Please review this change to the Unix implementations of > `sun.nio.ch.sctp.Sctp*ChannelImpl#kill()` to close the socket if `state == > ChannelState.UNINITIALIZED`. Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision: 8269481: Chan